Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720028

Re: [PATCH v2 1/5] sched/fair: Move select_task_rq_fair slow-path into its own function

Show all headers | View raw

On Fri, Aug 25, 2017 at 11:16:28AM +0100, Brendan Jackman wrote:
> In preparation for changes that would otherwise require adding a new
> level of indentation to the while(sd) loop, create a new function
> find_idlest_cpu which contains this loop, and rename the existing
> find_idlest_cpu to find_idlest_group_cpu.
> 
> Code inside the while(sd) loop is unchanged. @new_cpu is added as a
> variable in the new function, with the same initial value as the
> @new_cpu in select_task_rq_fair.
> 
> Suggested-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Brendan Jackman <brendan.jackman@arm.com>
> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Cc: Vincent Guittot <vincent.guittot@linaro.org>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Morten Rasmussen <morten.rasmussen@arm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> 
> squash! sched/fair: Move select_task_rq_fair slow-path into its own function
> ---
>  kernel/sched/fair.c | 83 +++++++++++++++++++++++++++++++----------------------
>  1 file changed, 48 insertions(+), 35 deletions(-)
> 
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index c95880e216f6..f6e277c65235 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5509,10 +5509,10 @@ find_idlest_group(struct sched_domain *sd, struct task_struct *p,
>  }
>  
>  /*
> - * find_idlest_cpu - find the idlest cpu among the cpus in group.
> + * find_idlest_group_cpu - find the idlest cpu among the cpus in group.
>   */
>  static int
> -find_idlest_cpu(struct sched_group *group, struct task_struct *p, int this_cpu)
> +find_idlest_group_cpu(struct sched_group *group, struct task_struct *p, int this_cpu)

I hate this name but can't think of something that isn't unreasonably long
either.

Reviewed-by: Josef Bacik <jbacik@fb.com>

Thanks,

Josef

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] sched/fair: Tweaks for select_task_rq_fair slowpath Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
  [PATCH v2 1/5] sched/fair: Move select_task_rq_fair slow-path into its own function Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
    Re: [PATCH v2 1/5] sched/fair: Move select_task_rq_fair slow-path  into its own function Josef Bacik <josef@toxicpanda.com> - 2017-08-25 14:30 +0200
    Re: [PATCH v2 1/5] sched/fair: Move select_task_rq_fair slow-path  into its own function Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:50 +0200
  [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest. Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
    Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when  local group is idlest. Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:40 +0200
      Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest. Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 18:00 +0200
        Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when  local group is idlest. Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-28 11:00 +0200
          Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when  local group is idlest. Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-28 11:20 +0200
          Re: [PATCH v2 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest. Brendan Jackman <brendan.jackman@arm.com> - 2017-08-29 19:20 +0200
  [PATCH v2 4/5] sched/fair: Fix use of find_idlest_group when no groups are allowed Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
    Re: [PATCH v2 4/5] sched/fair: Fix use of find_idlest_group when no  groups are allowed Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:40 +0200
  [PATCH v2 3/5] sched/fair: Fix find_idlest_group when local group is not allowed Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
    Re: [PATCH v2 3/5] sched/fair: Fix find_idlest_group when local group  is not allowed Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:50 +0200
  [PATCH v2 2/5] sched/fair: Remove unnecessary comparison with -1 Brendan Jackman <brendan.jackman@arm.com> - 2017-08-25 12:20 +0200
    Re: [PATCH v2 2/5] sched/fair: Remove unnecessary comparison with -1 Josef Bacik <josef@toxicpanda.com> - 2017-08-25 14:50 +0200
    Re: [PATCH v2 2/5] sched/fair: Remove unnecessary comparison with -1 Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-25 15:50 +0200

csiph-web