Groups > linux.kernel > #1719632

Re: [PATCH] Input: ambakmi: constify amba_id

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Input: ambakmi: constify amba_id
Date	2017-08-25 01:10 +0200
Message-ID	<ui9qa-4Bp-1@gated-at.bofh.it> (permalink)
References	<uhGxQ-2Nf-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 23, 2017 at 09:49:11PM +0530, Arvind Yadav wrote:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>

Applied, thank you.

> ---
>  drivers/input/serio/ambakmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c
> index c6606ca..ff3875c 100644
> --- a/drivers/input/serio/ambakmi.c
> +++ b/drivers/input/serio/ambakmi.c
> @@ -187,7 +187,7 @@ static int __maybe_unused amba_kmi_resume(struct device *dev)
>  
>  static SIMPLE_DEV_PM_OPS(amba_kmi_dev_pm_ops, NULL, amba_kmi_resume);
>  
> -static struct amba_id amba_kmi_idtable[] = {
> +static const struct amba_id amba_kmi_idtable[] = {
>  	{
>  		.id	= 0x00041050,
>  		.mask	= 0x000fffff,
> -- 
> 2.7.4
> 

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Input: ambakmi: constify amba_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-23 18:20 +0200
  Re: [PATCH] Input: ambakmi: constify amba_id Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-08-25 01:10 +0200

csiph-web