Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1718493 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-08-23 18:20 +0200 |
| Last post | 2017-08-25 01:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] Input: ambakmi: constify amba_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-23 18:20 +0200
Re: [PATCH] Input: ambakmi: constify amba_id Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-08-25 01:10 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-08-23 18:20 +0200 |
| Subject | [PATCH] Input: ambakmi: constify amba_id |
| Message-ID | <uhGxQ-2Nf-9@gated-at.bofh.it> |
amba_id are not supposed to change at runtime. All functions
working with const amba_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/input/serio/ambakmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c
index c6606ca..ff3875c 100644
--- a/drivers/input/serio/ambakmi.c
+++ b/drivers/input/serio/ambakmi.c
@@ -187,7 +187,7 @@ static int __maybe_unused amba_kmi_resume(struct device *dev)
static SIMPLE_DEV_PM_OPS(amba_kmi_dev_pm_ops, NULL, amba_kmi_resume);
-static struct amba_id amba_kmi_idtable[] = {
+static const struct amba_id amba_kmi_idtable[] = {
{
.id = 0x00041050,
.mask = 0x000fffff,
--
2.7.4
[toc] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-08-25 01:10 +0200 |
| Message-ID | <ui9qa-4Bp-1@gated-at.bofh.it> |
| In reply to | #1718493 |
On Wed, Aug 23, 2017 at 09:49:11PM +0530, Arvind Yadav wrote:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied, thank you.
> ---
> drivers/input/serio/ambakmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c
> index c6606ca..ff3875c 100644
> --- a/drivers/input/serio/ambakmi.c
> +++ b/drivers/input/serio/ambakmi.c
> @@ -187,7 +187,7 @@ static int __maybe_unused amba_kmi_resume(struct device *dev)
>
> static SIMPLE_DEV_PM_OPS(amba_kmi_dev_pm_ops, NULL, amba_kmi_resume);
>
> -static struct amba_id amba_kmi_idtable[] = {
> +static const struct amba_id amba_kmi_idtable[] = {
> {
> .id = 0x00041050,
> .mask = 0x000fffff,
> --
> 2.7.4
>
--
Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web