Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1717981

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

From "Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 00/14] mpt3sas driver NVMe support:
Date 2017-08-23 04:20 +0200
Message-ID <uhtqW-2RF-9@gated-at.bofh.it> (permalink)
References <ugV5T-4XE-13@gated-at.bofh.it>
Organization Oracle Corporation

Show all headers | View raw


Suganath,

>   mpt3sas: SGL to PRP Translation for I/Os to NVMe  devices

I'm still confused about this patch.

 - I don't understand why you go through all these hoops to decide
   whether to use PRPs or IEEE scatterlists. If the firmware translation
   is slow, why even bother with the SG format in the first place? Set
   the max I/O size to match MDTS and you're done.

 - What's the benefit of using SG for regular I/O commands?

 - If the unmap translation in firmware is slow, why don't you translate
   WRITE SAME/w UNMAP set to DSM DEALLOCATE without requiring
   applications to do encapsulated passthrough?

Also make sure you attribute your patches correctly (From: root
<root@dhcp-135-24-192-103.dhcp.avagotech.net>). And you don't need that
long CC: list. Just send the patch series to linux-scsi@vger.kernel.org.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v4 00/14] mpt3sas driver NVMe support: Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 13/14] mpt3sas: Update mpt3sas driver version. Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 05/14] mpt3sas: API 's to support NVMe drive addition to SML Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 04/14] mpt3sas: Added support for nvme encapsulated request message. Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 11/14] mpt3sas: NVMe drive support for BTDHMAPPING ioctl command and log info Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 02/14] mpt3sas: Add nvme device support in slave alloc, target alloc and probe Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 10/14] mpt3as: Add-Task-management-debug-info-for-NVMe-drives. Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 09/14] mpt3sas: scan and add nvme device after controller reset Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 12/14] mpt3sas: Fix nvme drives checking for tlr. Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 14/14] mpt3sas: Fix sparse warning Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 06/14] mpt3sas: API's to remove nvme drive from sml Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 03/14] mpt3sas: SGL to PRP Translation for I/Os to NVMe  devices Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 08/14] mpt3sas: Set NVMe device queue depth as 128 Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  [PATCH v4 07/14] mpt3sas: Handle NVMe PCIe device related events generated               from firmware. Suganath Prabu S <suganath-prabu.subramani@broadcom.com> - 2017-08-21 15:40 +0200
  Re: [PATCH v4 00/14] mpt3sas driver NVMe support: "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-08-23 04:20 +0200

csiph-web