Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1717980

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Show all headers | View raw

Hi Brian,

On 08/23/2017 09:57 AM, Brian Norris wrote:
> Hi Jeffy,
>
> On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote:
>> and for eage irq, maybe we should enable it right after(or before)
>> the driver activate wake function(for example activate WOWLAN or
>> WOLAN), otherwise would it be possible to miss some irqs(triggered
>> before we actually enable the wake irq)?
>
> I already mentioned this: for the PCI case, the specification explicitly
> says that the WAKE# pin must remain asserted until the system wakes and
> resets the link. So we don't have this problem.
Sorry, i means for other use cases of wakeirq, for example sdio wifi

>
> But it is probably still useful to make sure there's a well-defined
> point at which these interrupts are armed, so that if a device driver
> does care, it can account for that. Just before suspend_noirq (as it is
> today) is probably fine, so if there's some device-level handling that
> needs to happen before we get to suspend (but after the wakeirq is
> armed), it can go in the device or bus {suspend,resume}_noirq callbacks.

Yes, then we may need to handle "disable level irq" job in the irq 
handler(or runtime resume callback as current wakeirq API suggested) for 
irqs received before suspend devices irqs.
>
> Brian
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 0/3] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-17 14:10 +0200
  [RFC PATCH v2 3/3] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-17 14:10 +0200
  [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-08-17 14:10 +0200
    Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Shawn Lin <shawn.lin@rock-chips.com> - 2017-08-18 09:30 +0200
      Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq jeffy <jeffy.chen@rock-chips.com> - 2017-08-18 10:40 +0200
    Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Brian Norris <briannorris@chromium.org> - 2017-08-18 19:10 +0200
      Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Brian Norris <briannorris@chromium.org> - 2017-08-18 19:10 +0200
      Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq jeffy <jeffy.chen@rock-chips.com> - 2017-08-18 19:50 +0200
        Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Tony Lindgren <tony@atomide.com> - 2017-08-18 20:30 +0200
      Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Tony Lindgren <tony@atomide.com> - 2017-08-18 20:20 +0200
        Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq jeffy <jeffy.chen@rock-chips.com> - 2017-08-18 22:10 +0200
          Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Tony Lindgren <tony@atomide.com> - 2017-08-22 19:30 +0200
            Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq jeffy <jeffy.chen@rock-chips.com> - 2017-08-23 03:40 +0200
              Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq Brian Norris <briannorris@chromium.org> - 2017-08-23 04:00 +0200
                Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq jeffy <jeffy.chen@rock-chips.com> - 2017-08-23 04:20 +0200

csiph-web