Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1714288

Re: [PATCH] kernfs: Clarify lockdep name for kn->count

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] kernfs: Clarify lockdep name for kn->count
Date 2017-08-17 20:50 +0200
Message-ID <ufy1H-iq-5@gated-at.bofh.it> (permalink)
References <ufvnb-6Uk-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Aug 17, 2017 at 11:49:56AM -0400, Waiman Long wrote:
> The reference count in kernfs_node structure is treated like a rwsem by
> using lockdep instrumentation code. The lockdep name, however, is still
> "s_active" which is carried over from the old sysfs code. As s_active
> is no longer the variable name, its use may confuse users on where the
> lock is when it is reported by lockdep. So it is changed to "kn->count"
> which is how this variable is normally referenced in kernfs code.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] kernfs: Clarify lockdep name for kn->count Waiman Long <longman@redhat.com> - 2017-08-17 18:00 +0200
  Re: [PATCH] kernfs: Clarify lockdep name for kn->count Tejun Heo <tj@kernel.org> - 2017-08-17 20:50 +0200

csiph-web