Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1714173 > unrolled thread

[PATCH] kernfs: Clarify lockdep name for kn->count

Back to article view | Back to linux.kernel

Contents

  [PATCH] kernfs: Clarify lockdep name for kn->count Waiman Long <longman@redhat.com> - 2017-08-17 18:00 +0200
    Re: [PATCH] kernfs: Clarify lockdep name for kn->count Tejun Heo <tj@kernel.org> - 2017-08-17 20:50 +0200

#1714173 — [PATCH] kernfs: Clarify lockdep name for kn->count

The reference count in kernfs_node structure is treated like a rwsem by
using lockdep instrumentation code. The lockdep name, however, is still
"s_active" which is carried over from the old sysfs code. As s_active
is no longer the variable name, its use may confuse users on where the
lock is when it is reported by lockdep. So it is changed to "kn->count"
which is how this variable is normally referenced in kernfs code.

Signed-off-by: Waiman Long <longman@redhat.com>
---
 fs/kernfs/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index ac2dfe0..e6c8954 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -997,7 +997,7 @@ struct kernfs_node *__kernfs_create_file(struct kernfs_node *parent,
 
 #ifdef CONFIG_DEBUG_LOCK_ALLOC
 	if (key) {
-		lockdep_init_map(&kn->dep_map, "s_active", key, 0);
+		lockdep_init_map(&kn->dep_map, "kn->count", key, 0);
 		kn->flags |= KERNFS_LOCKDEP;
 	}
 #endif
-- 
1.8.3.1

[toc] | [next] | [standalone]

#1714288

On Thu, Aug 17, 2017 at 11:49:56AM -0400, Waiman Long wrote:
> The reference count in kernfs_node structure is treated like a rwsem by
> using lockdep instrumentation code. The lockdep name, however, is still
> "s_active" which is carried over from the old sysfs code. As s_active
> is no longer the variable name, its use may confuse users on where the
> lock is when it is reported by lockdep. So it is changed to "kn->count"
> which is how this variable is normally referenced in kernfs code.
> 
> Signed-off-by: Waiman Long <longman@redhat.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web