Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1712953

Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

Show all headers | View raw

On 08/16/2017 03:06 PM, Dan Carpenter wrote:
> On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The previous fix removed the equal to zero comparisons by the strcmps and
>> now the function always returns true. Fix this by adding in the missing
>> logical negation operators.
>>
>> Detected by CoverityScan, CID#1452267 ("Constant expression result")
>>
>> Fixes: b93ad9a067e1 ("staging: fsl-mc: be consistent when checking strcmp() return")

Thanks Colin (and Coverity) for catching this!

> Ugh...  I did review the original patch at all.  Sorry.

As a side note, funny how i got the patch description right but not the 
actual patch. :-)

> It's better to use "== 0" because it's idiomatic.

Agree, plus this approach would be consistent with the rest of the 
driver (except one place in drivers/staging/fsl-mc/bus/dprc-driver.c +32)

---
Best Regards, Laurentiu

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Colin King <colin.king@canonical.com> - 2017-08-16 13:50 +0200
  Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-16 14:10 +0200
    Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-16 14:20 +0200
    Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Laurentiu Tudor <laurentiu.tudor@nxp.com> - 2017-08-16 15:40 +0200
      Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Colin Ian King <colin.king@canonical.com> - 2017-08-16 16:20 +0200

csiph-web