[PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps
Date	2017-08-16 13:50 +0200
Message-ID	<uf4ZI-6ww-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The previous fix removed the equal to zero comparisons by the strcmps and
now the function always returns true. Fix this by adding in the missing
logical negation operators.

Detected by CoverityScan, CID#1452267 ("Constant expression result")

Fixes: b93ad9a067e1 ("staging: fsl-mc: be consistent when checking strcmp() return")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
index b37a6f48225f..8b5f2d0cdf06 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
@@ -16,9 +16,9 @@
 
 static bool __must_check fsl_mc_is_allocatable(const char *obj_type)
 {
-	return strcmp(obj_type, "dpbp") ||
-	       strcmp(obj_type, "dpmcp") ||
-	       strcmp(obj_type, "dpcon");
+	return !strcmp(obj_type, "dpbp") ||
+	       !strcmp(obj_type, "dpmcp") ||
+	       !strcmp(obj_type, "dpcon");
 }
 
 /**
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Colin King <colin.king@canonical.com> - 2017-08-16 13:50 +0200
  Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-16 14:10 +0200
    Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-16 14:20 +0200
    Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Laurentiu Tudor <laurentiu.tudor@nxp.com> - 2017-08-16 15:40 +0200
      Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps Colin Ian King <colin.king@canonical.com> - 2017-08-16 16:20 +0200

csiph-web