Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1711262

Re: [PATCH] irq_work: improve the flag definitions

Show all headers | View raw

2017-08-14 14:19 GMT+02:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> On Mon, Aug 14, 2017 at 2:56 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>> IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it
>> says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise
>> OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY.
>>
>> While we're at it: use the BIT() macro for all flags.
>
>> +#define IRQ_WORK_PENDING       BIT(0)
>> +#define IRQ_WORK_BUSY          BIT(1)
>> +#define IRQ_WORK_FLAGS         (IRQ_WORK_PENDING | IRQ_WORK_BUSY)
>
> I dunno which style is preferred, though I would go with simple
> GENMASK() here, as all definitions right on left :-)
>
> Parameters of GENMASK will show last-first entries and can be easily decoded.
> Although there are only two for now.
>

Which is a good enough reason to not over-complicate things and just
use an easy to decipher bitwise OR. ;)

Thanks,
Bartosz

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] irq_work: improve the flag definitions Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 14:00 +0200
  Re: [PATCH] irq_work: improve the flag definitions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-14 14:20 +0200
    Re: [PATCH] irq_work: improve the flag definitions Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 19:20 +0200
  Re: [PATCH] irq_work: improve the flag definitions Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-15 11:20 +0200

csiph-web