Re: [PATCH] irq_work: improve the flag definitions

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Bartosz Golaszewski <brgl@bgdev.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irq_work: improve the flag definitions
Date	Mon, 14 Aug 2017 19:20:02 +0200
Message-ID	<uerbY-6WD-3@gated-at.bofh.it> (permalink)
References	<uemci-3H5-11@gated-at.bofh.it> <uemvD-42v-11@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZLL8NeeN7c8RvlwRfoIM+m1KZCCEVO8U4KC+VcHVu7Y=; b=BFREEW++aqYlWlMZtDO0WWbNQVg8dUzXLEUjFy1T85aYJFg9XyhCvGcye4mDmOBJSo 5Xs6ZbUD5AyDxv4ClO/++N0d44RRjyqGHt3yS60DCMScdwlhfoUwXqlnOrDVST78xVIT HBsJRtxAqYXL/1bCnS4IBBcjMt2XGi1D9nLqygnpyXKcRzkQb7ioopav7OwEwuAhBcqZ rFMSz/50bOJz6u0tK0Tu6r/ZRBXV5qWW+IOuA5sd6tjuajzjtXsrSIf9FyfA9NUZe3Tb CGKVQi/ZO1Wk0cvneKTDje9VPW0FIHESL58bGGfXHzqh/r1TTTbDGo6oor1Je1XmalKp zjpw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZLL8NeeN7c8RvlwRfoIM+m1KZCCEVO8U4KC+VcHVu7Y=; b=mKaWlo1e13o/36DjPHZSx57vVptlVRnZdZ0qYigJ2PMfnr1jc1pAhJYMgLJFbQRaXq L6vdppZg5rSNf8xJDziiWh6WQ86D9TSKOiJeBrV0Ms21kUirfBlnWAT647uL0z2JHKUH pjk+VKvOS2c624DX91uz1zNZPwwo/ULOzSVWe59lib7sFi52NfNVkE91FdtJixq8QUgV Iy0KsR0ucMjOLcfjXNtGXpFX84RepkASDQsmWC6sGE0Sdq7yPvdlVq/obiF9RdlkT4VR 7KSc8AkKxyLNfAInmLE1ykxMFpQ0IBs/PSSLMOJk0huqA5e3yz95gb+MOCenEdZHSqFE /4Hw==
X-Gm-Message-State	AHYfb5jYC/u85f/ix70yHrsvGItrHIb5Hou5FfszxNZOzbAGgGSRpULf VxrGcIWWNAQ625PRBlzTU5WMFBOE5H3n
X-Received	by 10.55.107.130 with SMTP id g124mr32030779qkc.210.1502730737063; Mon, 14 Aug 2017 10:12:17 -0700 (PDT)
MIME-Version	1.0
X-Originating-IP	[90.116.248.41]
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <marc.zyngier@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 14 Aug 2017 19:12:16 +0200
X-Original-Message-ID	<CAMRc=Mf9Xn4E=iPpVBdQe_6mUG4JQBmt7gL41kOpvbjYWX8pOQ@mail.gmail.com>
X-Original-References	<20170814115647.21955-1-brgl@bgdev.pl> <CAHp75VcqQGgkkuoxpNheBPDtjWqY1CGAVd1RS2Vh0Kp29vfOLQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1711262

Show key headers only | View raw

2017-08-14 14:19 GMT+02:00 Andy Shevchenko <andy.shevchenko@gmail.com>:
> On Mon, Aug 14, 2017 at 2:56 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>> IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it
>> says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise
>> OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY.
>>
>> While we're at it: use the BIT() macro for all flags.
>
>> +#define IRQ_WORK_PENDING       BIT(0)
>> +#define IRQ_WORK_BUSY          BIT(1)
>> +#define IRQ_WORK_FLAGS         (IRQ_WORK_PENDING | IRQ_WORK_BUSY)
>
> I dunno which style is preferred, though I would go with simple
> GENMASK() here, as all definitions right on left :-)
>
> Parameters of GENMASK will show last-first entries and can be easily decoded.
> Although there are only two for now.
>

Which is a good enough reason to not over-complicate things and just
use an easy to decipher bitwise OR. ;)

Thanks,
Bartosz

Thread

[PATCH] irq_work: improve the flag definitions Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 14:00 +0200
  Re: [PATCH] irq_work: improve the flag definitions Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-14 14:20 +0200
    Re: [PATCH] irq_work: improve the flag definitions Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-14 19:20 +0200
  Re: [PATCH] irq_work: improve the flag definitions Bartosz Golaszewski <brgl@bgdev.pl> - 2017-08-15 11:20 +0200

csiph-web