Re: [PATCH 1/2] f2fs: use IPU for cold files

From	Chao Yu <yuchao0@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] f2fs: use IPU for cold files
Date	2017-08-08 05:00 +0200
Message-ID	<uc2Up-1xb-7@gated-at.bofh.it> (permalink)
References	<uc1OG-E4-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017/8/8 9:42, Jaegeuk Kim wrote:
> We expect cold files write data sequentially, but sometimes some of small data
> can be updated, which incurs fragmentation.
> Let's avoid that.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

> ---
>  fs/f2fs/segment.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
> index 6b871b492fd5..7f700e54b77d 100644
> --- a/fs/f2fs/segment.h
> +++ b/fs/f2fs/segment.h
> @@ -577,6 +577,10 @@ static inline bool need_inplace_update_policy(struct inode *inode,
>  	if (test_opt(sbi, LFS))
>  		return false;
>  
> +	/* if this is cold file, we should overwrite to avoid fragmentation */
> +	if (file_is_cold(inode))
> +		return true;
> +
>  	if (policy & (0x1 << F2FS_IPU_FORCE))
>  		return true;
>  	if (policy & (0x1 << F2FS_IPU_SSR) && need_SSR(sbi))
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] f2fs: use IPU for cold files Jaegeuk Kim <jaegeuk@kernel.org> - 2017-08-08 03:50 +0200
  [PATCH 2/2] f2fs: introduce gc_urgent mode for background GC Jaegeuk Kim <jaegeuk@kernel.org> - 2017-08-08 03:50 +0200
    Re: [PATCH 2/2 v2] f2fs: introduce gc_urgent mode for background GC Jaegeuk Kim <jaegeuk@kernel.org> - 2017-08-08 05:10 +0200
    Re: [PATCH 2/2] f2fs: introduce gc_urgent mode for background GC Chao Yu <yuchao0@huawei.com> - 2017-08-08 05:20 +0200
      Re: [PATCH 2/2] f2fs: introduce gc_urgent mode for background GC Jaegeuk Kim <jaegeuk@kernel.org> - 2017-08-08 05:50 +0200
    Re: [PATCH 2/2] f2fs: introduce gc_urgent mode for background GC Chao Yu <yuchao0@huawei.com> - 2017-08-10 12:50 +0200
  Re: [PATCH 1/2] f2fs: use IPU for cold files Chao Yu <yuchao0@huawei.com> - 2017-08-08 05:00 +0200

csiph-web