Re: [PATCH 0/8] constify input usb_device_id.

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/8] constify input usb_device_id.
Date	2017-08-08 05:10 +0200
Message-ID	<uc345-1QI-1@gated-at.bofh.it> (permalink)
References	<ubotX-7MP-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Aug 06, 2017 at 01:11:19PM +0530, Arvind Yadav wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Fix checkpatch.pl error in patch 1,3 and 7:
> ERROR: space prohibited before open square bracket '['.
> 
> Arvind Yadav (8):
>   [PATCH 1/8] Input: iforce: constify usb_device_id and fix space before '[' error.
>   [PATCH 2/8] Input: xpad: constify usb_device_id.
>   [PATCH 3/8] Input: keyspan_remote: constify usb_device_id.
>   [PATCH 4/8] Input: powermate: constify usb_device_id and fix space before '[' error.
>   [PATCH 5/8] Input: appletouch: constify usb_device_id.
>   [PATCH 6/8] Input: synaptics_usb: constify usb_device_id.
>   [PATCH 7/8] Input: acecad: constify usb_device_id and fix space before '[' error.
>   [PATCH 8/8] Input: kbtab: constify usb_device_id.
> 
>  drivers/input/joystick/iforce/iforce-usb.c | 2 +-
>  drivers/input/joystick/xpad.c              | 2 +-
>  drivers/input/misc/keyspan_remote.c        | 2 +-
>  drivers/input/misc/powermate.c             | 2 +-
>  drivers/input/mouse/appletouch.c           | 2 +-
>  drivers/input/mouse/synaptics_usb.c        | 2 +-
>  drivers/input/tablet/acecad.c              | 2 +-
>  drivers/input/tablet/kbtab.c               | 2 +-
>  8 files changed, 8 insertions(+), 8 deletions(-)

Applied the lot, thank you.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] constify input usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:50 +0200
  [PATCH 8/8] Input: kbtab: constify usb_device_id. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-06 09:50 +0200
  Re: [PATCH 0/8] constify input usb_device_id. Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-08-08 05:10 +0200

csiph-web