Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1699962
| From | David Laight <David.Laight@ACULAB.COM> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly |
| Date | 2017-07-31 13:50 +0200 |
| Message-ID | <u9hmV-5Mi-3@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <u8fdw-5s4-23@gated-at.bofh.it> <u8fGx-5Cs-7@gated-at.bofh.it> <u8gjg-65z-13@gated-at.bofh.it> <u8gMh-6gp-9@gated-at.bofh.it> <u8gVY-6za-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Florian Fainelli > Sent: 28 July 2017 18:05 ... > >>>> +EXPORT_SYMBOL(lan9303_indirect_phy_ops); > >>> > >>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL? > >> > >> I have no opinion. I just used the same variant as the other EXPORTS > >> in the file. > > > > If there is no concern from others about this, LGTM too: > > Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem > to be appropriate, which can be done as a subsequent patch. It depends on whether the function needs to be usable by 'out of tree' non-GPL modules. This looks like a 'private' export between related modules. The problems arise with functions like put_ns() and put_pid() which can easily be needed by non-GPL code. David
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues. Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
[PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:50 +0200
Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
[PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:40 +0200
Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
[PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:20 +0200
Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:40 +0200
Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
[PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:50 +0200
Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 18:30 +0200
Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 19:00 +0200
Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 21:50 +0200
Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Andrew Lunn <andrew@lunn.ch> - 2017-07-28 23:30 +0200
Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-29 00:40 +0200
RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly David Laight <David.Laight@ACULAB.COM> - 2017-07-31 13:50 +0200
Re: [PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues. Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
csiph-web