RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	David Laight <David.Laight@ACULAB.COM>
Newsgroups	linux.kernel
Subject	RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly
Date	Mon, 31 Jul 2017 13:50:01 +0200
Message-ID	<u9hmV-5Mi-3@gated-at.bofh.it> (permalink)
References	<u8fdw-5s4-3@gated-at.bofh.it> <u8fdw-5s4-23@gated-at.bofh.it> <u8fGx-5Cs-7@gated-at.bofh.it> <u8gjg-65z-13@gated-at.bofh.it> <u8gMh-6gp-9@gated-at.bofh.it> <u8gVY-6za-15@gated-at.bofh.it>
X-Original-To	'Florian Fainelli' <f.fainelli@gmail.com>, Vivien Didelot <vivien.didelot@savoirfairelinux.com>, Egil Hjelmeland <privat@egil-hjelmeland.no>, "andrew@lunn.ch" <andrew@lunn.ch>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>
Thread-Topic	[PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly
Thread-Index	AQHTB8OwO4fnTRgDQkOMO1lE2MBY/6Jt0XFA
Accept-Language	en-GB, en-US
Content-Language	en-US
X-Originating-IP	[10.202.99.200]
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	base64
MIME-Version	1.0
X-Outbound-IP	156.67.243.126
X-Env-From	David.Laight@ACULAB.COM
X-Proto	esmtps
X-Helo	AcuExch.aculab.com
X-Tls	TLSv1:AES128-SHA:128
X-Policysmart	3396946, 3397078
X-Virus-Status	Scanned by VirusSMART (c)
X-Virus-Status	Scanned by VirusSMART (s)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	14
Organization	linux.* mail to news gateway
X-Original-Date	Mon, 31 Jul 2017 11:44:15 +0000
X-Original-Message-ID	<063D6719AE5E284EB5DD2968C1650D6DD0047300@AcuExch.aculab.com>
X-Original-References	<20170728151157.28983-1-privat@egil-hjelmeland.no> <20170728151157.28983-5-privat@egil-hjelmeland.no> <87fudglget.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <50d2d34c-c1a5-7f0a-90f1-44b1be1775b7@egil-hjelmeland.no> <87fudgqz4w.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <1250382a-1c17-8e82-8c5c-fe14786c84db@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1699962

Show key headers only | View raw

From: Florian Fainelli
> Sent: 28 July 2017 18:05
...
> >>>> +EXPORT_SYMBOL(lan9303_indirect_phy_ops);
> >>>
> >>> Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL?
> >>
> >> I have no opinion. I just used the same variant as the other EXPORTS
> >> in the file.
> >
> > If there is no concern from others about this, LGTM too:
> 
> Since the kernel module license is GPL, EXPORT_SYMBOL_GPL() would seem
> to be appropriate, which can be done as a subsequent patch.

It depends on whether the function needs to be usable by 'out of tree'
non-GPL modules.
This looks like a 'private' export between related modules.
The problems arise with functions like put_ns() and put_pid()
which can easily be needed by non-GPL code.

	David

Thread

[PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues. Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
  [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
    Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy  access functions Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
    Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:50 +0200
    Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy  access functions Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
  [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
    Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get  MDIO register Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
    Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:40 +0200
    Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO  register Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
  [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
    Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix  lan9303_detect_phy_setup() for MDIO Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:20 +0200
    Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:40 +0200
    Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix  lan9303_detect_phy_setup() for MDIO Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
  [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 17:20 +0200
    Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy  registers directly Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200
    Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 17:50 +0200
      Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers  directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 18:30 +0200
        Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-07-28 19:00 +0200
          Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers  directly Florian Fainelli <f.fainelli@gmail.com> - 2017-07-28 19:10 +0200
            Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers  directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-28 21:50 +0200
              Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy  registers directly Andrew Lunn <andrew@lunn.ch> - 2017-07-28 23:30 +0200
                Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers  directly Egil Hjelmeland <privat@egil-hjelmeland.no> - 2017-07-29 00:40 +0200
            RE: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy  registers directly David Laight <David.Laight@ACULAB.COM> - 2017-07-31 13:50 +0200
  Re: [PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues. Andrew Lunn <andrew@lunn.ch> - 2017-07-28 17:30 +0200

csiph-web