Re: [PATCH] mm: don't zero ballooned pages

From	Wei Wang <wei.w.wang@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: don't zero ballooned pages
Date	2017-07-31 10:40 +0200
Message-ID	<u9ep4-3Xg-13@gated-at.bofh.it> (permalink)
References	<u9av8-1yG-7@gated-at.bofh.it> <u9cQi-2Wn-11@gated-at.bofh.it> <u9dt0-3oE-19@gated-at.bofh.it> <u9dCG-3sb-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/31/2017 03:43 PM, Michal Hocko wrote:
> On Mon 31-07-17 15:41:49, Wei Wang wrote:
>> On 07/31/2017 02:55 PM, Michal Hocko wrote:
>>> On Mon 31-07-17 12:13:33, Wei Wang wrote:
>>>> Ballooned pages will be marked as MADV_DONTNEED by the hypervisor and
>>>> shouldn't be given to the host ksmd to scan.
>>> Could you point me where this MADV_DONTNEED is done, please?
>> Sure. It's done in the hypervisor when the balloon pages are received.
>>
>> Please see line 40 at
>> https://github.com/qemu/qemu/blob/master/hw/virtio/virtio-balloon.c
> Thanks. Are all hypervisors which are using this API doing this?

The implementation may be different across different hypervisors.
But the underlying concept is the same - they unmap the balloon
pages from the guest and those pages will be given to other guests
or host processes to use.

Regardless of the implementation, I think it is an improper operation
to make the memory KSM mergeable when the memory does not
belong to the guest anymore.

Best,
Wei

Thread

[PATCH] mm: don't zero ballooned pages Wei Wang <wei.w.wang@intel.com> - 2017-07-31 06:30 +0200
  Re: [PATCH] mm: don't zero ballooned pages Michal Hocko <mhocko@kernel.org> - 2017-07-31 09:00 +0200
    Re: [PATCH] mm: don't zero ballooned pages Wei Wang <wei.w.wang@intel.com> - 2017-07-31 09:40 +0200
      Re: [PATCH] mm: don't zero ballooned pages Michal Hocko <mhocko@kernel.org> - 2017-07-31 09:50 +0200
        Re: [PATCH] mm: don't zero ballooned pages Wei Wang <wei.w.wang@intel.com> - 2017-07-31 10:40 +0200
      Re: [PATCH] mm: don't zero ballooned pages Michal Hocko <mhocko@kernel.org> - 2017-07-31 10:00 +0200
        Re: [PATCH] mm: don't zero ballooned pages Michal Hocko <mhocko@kernel.org> - 2017-07-31 10:40 +0200
          Re: [PATCH] mm: don't zero ballooned pages "Michael S. Tsirkin" <mst@redhat.com> - 2017-08-01 17:40 +0200
    Re: [PATCH] mm: don't zero ballooned pages ZhenweiPi <zhenwei.pi@youruncloud.com> - 2017-07-31 09:40 +0200

csiph-web