Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1701591

Re: [PATCH] sysfs: replace WARN() with pr_debug in sysfs_remove_group()

Show all headers | View raw

Grep,


On 2017/8/2 2:06, Greg KH wrote:
> On Tue, Aug 01, 2017 at 05:02:25PM +0900, Ethan Zhao wrote:
>> There is no enough error handling in block device adding/registration
>> path, for example,
>>
>> device_add_disk()
>>    blk_register_queue()
>>
>> When kernel returns from device_add_disk(), no return value to tell
>> us it was successful or not --- that suggests it would always succeed,
>> and according to this assumption, then during block device removal/
>> unregistration steps,
>>
>> sd_remove()
>>    del_gendisk()
>>      blk_unregister_queue()
>>
>> dpm_sysfs_remove(), blk_trace_remove_sysfs() will be called blindly,
>> though there is likely no 'trace' 'power' sysfs groups there because
>> actually blk_register_queue()/device_add() failed somewhere. thus
>> causes WARN flood emitted from sysfs_remove_group() as following triggered
>> by unloading fnic driver:
> Then fix the real issue here, don't paper over the issue by changing the
> sysfs core please.  No other subsystem seems to be having this issue.
   Yep, I agree it is kind of cover up block layer issue.

  Thanks,
  Ethan
> thanks,
>
> greg k-h
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sysfs: replace WARN() with pr_debug in sysfs_remove_group() Ethan Zhao <ethan.zhao@oracle.com> - 2017-08-01 11:10 +0200
  Re: [PATCH] sysfs: replace WARN() with pr_debug in  sysfs_remove_group() Greg KH <gregkh@linuxfoundation.org> - 2017-08-01 20:10 +0200
    Re: [PATCH] sysfs: replace WARN() with pr_debug in  sysfs_remove_group() Ethan Zhao <ethan.zhao@oracle.com> - 2017-08-02 01:50 +0200

csiph-web