Re: [PATCH] sysfs: replace WARN() with pr_debug in sysfs_remove_group()

Path	csiph.com!news.freedyn.net!open-news-network.org!aioe.org!bofh.it!news.nic.it!robomod
From	Ethan Zhao <ethan.zhao@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sysfs: replace WARN() with pr_debug in sysfs_remove_group()
Date	Wed, 02 Aug 2017 01:50:01 +0200
Message-ID	<u9P5f-28a-7@gated-at.bofh.it> (permalink)
References	<u9BlF-1r3-47@gated-at.bofh.it> <u9JMf-7ne-37@gated-at.bofh.it>
X-Original-To	Greg KH <gregkh@linuxfoundation.org>
Organization	Oracle Corporation
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
X-Source-IP	aserv0022.oracle.com [141.146.126.234]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
X-Original-Cc	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, ethan.kernel@gmail.com
X-Original-Date	Wed, 2 Aug 2017 07:49:37 +0800
X-Original-Message-ID	<a5701c95-304a-e727-48eb-55ffeec04013@oracle.com>
X-Original-References	<1501574545-15691-1-git-send-email-ethan.zhao@oracle.com> <20170801180635.GA31628@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1701591

Show key headers only | View raw

Grep,


On 2017/8/2 2:06, Greg KH wrote:
> On Tue, Aug 01, 2017 at 05:02:25PM +0900, Ethan Zhao wrote:
>> There is no enough error handling in block device adding/registration
>> path, for example,
>>
>> device_add_disk()
>>    blk_register_queue()
>>
>> When kernel returns from device_add_disk(), no return value to tell
>> us it was successful or not --- that suggests it would always succeed,
>> and according to this assumption, then during block device removal/
>> unregistration steps,
>>
>> sd_remove()
>>    del_gendisk()
>>      blk_unregister_queue()
>>
>> dpm_sysfs_remove(), blk_trace_remove_sysfs() will be called blindly,
>> though there is likely no 'trace' 'power' sysfs groups there because
>> actually blk_register_queue()/device_add() failed somewhere. thus
>> causes WARN flood emitted from sysfs_remove_group() as following triggered
>> by unloading fnic driver:
> Then fix the real issue here, don't paper over the issue by changing the
> sysfs core please.  No other subsystem seems to be having this issue.
   Yep, I agree it is kind of cover up block layer issue.

  Thanks,
  Ethan
> thanks,
>
> greg k-h
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sysfs: replace WARN() with pr_debug in sysfs_remove_group() Ethan Zhao <ethan.zhao@oracle.com> - 2017-08-01 11:10 +0200
  Re: [PATCH] sysfs: replace WARN() with pr_debug in  sysfs_remove_group() Greg KH <gregkh@linuxfoundation.org> - 2017-08-01 20:10 +0200
    Re: [PATCH] sysfs: replace WARN() with pr_debug in  sysfs_remove_group() Ethan Zhao <ethan.zhao@oracle.com> - 2017-08-02 01:50 +0200

csiph-web