Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback

From	Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback
Date	2017-07-25 16:20 +0200
Message-ID	<u78QN-3RN-3@gated-at.bofh.it> (permalink)
References	<u52w9-4uk-5@gated-at.bofh.it> <u52w9-4uk-9@gated-at.bofh.it> <u6OIq-7tA-11@gated-at.bofh.it> <u6PO9-8bd-1@gated-at.bofh.it> <u77L4-3dw-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 25/07/2017 15:08, Marc Gonzalez wrote:

> irq_gc_mask_disable_reg_and_ack() is not equivalent to
> irq_gc_mask_disable_reg() and irq_gc_ack_set_bit().
> 
> Leave the irq_mask_ack callback undefined, and let the irqchip
> framework use irq_mask and irq_ack instead.
> 
> Reported-by: Doug Berger <opendmb@gmail.com>
> Fixes: 4bba66899ac6 ("irqchip/tango: Add support for Sigma Designs SMP86xx/SMP87xx interrupt controller")
> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
> Cc: stable@vger.kernel.org

FWIW, the lockup reported in the thread below disappears
once the patch is applied.

https://lkml.org/lkml/2016/10/21/709

Regards.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/6] irqchip/tango: Use irq_gc_mask_disable_and_ack_set Doug Berger <opendmb@gmail.com> - 2017-07-19 21:10 +0200
  Re: [PATCH v2 2/6] irqchip/tango: Use irq_gc_mask_disable_and_ack_set Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-24 18:50 +0200
    Re: [PATCH v2 2/6] irqchip/tango: Use irq_gc_mask_disable_and_ack_set Doug Berger <opendmb@gmail.com> - 2017-07-24 20:00 +0200
      [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-25 15:10 +0200
        Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Måns Rullgård <mans@mansr.com> - 2017-07-25 15:20 +0200
          Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack  callback Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-25 15:30 +0200
            Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Måns Rullgård <mans@mansr.com> - 2017-07-25 15:30 +0200
              Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack  callback Florian Fainelli <f.fainelli@gmail.com> - 2017-07-26 20:30 +0200
                Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Måns Rullgård <mans@mansr.com> - 2017-07-26 21:20 +0200
                Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack  callback Florian Fainelli <f.fainelli@gmail.com> - 2017-07-27 20:20 +0200
                Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack  callback Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-28 16:10 +0200
        Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack  callback Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-25 16:20 +0200

csiph-web