Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1695716
| From | Marc Gonzalez <marc_gonzalez@sigmadesigns.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback |
| Date | 2017-07-25 15:10 +0200 |
| Message-ID | <u77L4-3dw-9@gated-at.bofh.it> (permalink) |
| References | <u52w9-4uk-5@gated-at.bofh.it> <u52w9-4uk-9@gated-at.bofh.it> <u6OIq-7tA-11@gated-at.bofh.it> <u6PO9-8bd-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
irq_gc_mask_disable_reg_and_ack() is not equivalent to
irq_gc_mask_disable_reg() and irq_gc_ack_set_bit().
Leave the irq_mask_ack callback undefined, and let the irqchip
framework use irq_mask and irq_ack instead.
Reported-by: Doug Berger <opendmb@gmail.com>
Fixes: 4bba66899ac6 ("irqchip/tango: Add support for Sigma Designs SMP86xx/SMP87xx interrupt controller")
Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Cc: stable@vger.kernel.org
---
As discussed previously, it is acceptable for tango to rely
on mask_ack_irq() doing the right thing(TM).
---
drivers/irqchip/irq-tango.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/irqchip/irq-tango.c b/drivers/irqchip/irq-tango.c
index bdbb5c0ff7fe..825085cdab99 100644
--- a/drivers/irqchip/irq-tango.c
+++ b/drivers/irqchip/irq-tango.c
@@ -141,7 +141,6 @@ static void __init tangox_irq_init_chip(struct irq_chip_generic *gc,
for (i = 0; i < 2; i++) {
ct[i].chip.irq_ack = irq_gc_ack_set_bit;
ct[i].chip.irq_mask = irq_gc_mask_disable_reg;
- ct[i].chip.irq_mask_ack = irq_gc_mask_disable_reg_and_ack;
ct[i].chip.irq_unmask = irq_gc_unmask_enable_reg;
ct[i].chip.irq_set_type = tangox_irq_set_type;
ct[i].chip.name = gc->domain->name;
--
2.11.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 2/6] irqchip/tango: Use irq_gc_mask_disable_and_ack_set Doug Berger <opendmb@gmail.com> - 2017-07-19 21:10 +0200
Re: [PATCH v2 2/6] irqchip/tango: Use irq_gc_mask_disable_and_ack_set Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-24 18:50 +0200
Re: [PATCH v2 2/6] irqchip/tango: Use irq_gc_mask_disable_and_ack_set Doug Berger <opendmb@gmail.com> - 2017-07-24 20:00 +0200
[PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-25 15:10 +0200
Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Måns Rullgård <mans@mansr.com> - 2017-07-25 15:20 +0200
Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-25 15:30 +0200
Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Måns Rullgård <mans@mansr.com> - 2017-07-25 15:30 +0200
Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Florian Fainelli <f.fainelli@gmail.com> - 2017-07-26 20:30 +0200
Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Måns Rullgård <mans@mansr.com> - 2017-07-26 21:20 +0200
Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Florian Fainelli <f.fainelli@gmail.com> - 2017-07-27 20:20 +0200
Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-28 16:10 +0200
Re: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2017-07-25 16:20 +0200
csiph-web