Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692082

Re: [PATCH] msi-wmi: remove unnecessary static in msi_wmi_notify()

Show all headers | View raw

On Wed, Jul 19, 2017 at 12:49 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Remove unnecessary static on local variable _key_. Such variable is
> initialized before being used, on every execution path throughout
> the function. The static has no benefit and, removing it reduces
> the object file size.
>
> This issue was detected using Coccinelle and the following semantic patch:
> https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci
>
> In the following log you can see a significant difference in the object
> file size. Also, there is a significant difference in the bss segment.
> This log is the output of the size command, before and after the code
> change:
>
> before:
>    text    data     bss     dec     hex filename
>    6530    3736     320   10586    295a drivers/platform/x86/msi-wmi.o
>
> after:
>    text    data     bss     dec     hex filename
>    6494    3648     256   10398    289e drivers/platform/x86/msi-wmi.o
>

Pushed to testing, thanks.

P.S. Please, use subsystem prefix next time.

> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/platform/x86/msi-wmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c
> index f6209b7..6201382 100644
> --- a/drivers/platform/x86/msi-wmi.c
> +++ b/drivers/platform/x86/msi-wmi.c
> @@ -184,7 +184,7 @@ static const struct backlight_ops msi_backlight_ops = {
>  static void msi_wmi_notify(u32 value, void *context)
>  {
>         struct acpi_buffer response = { ACPI_ALLOCATE_BUFFER, NULL };
> -       static struct key_entry *key;
> +       struct key_entry *key;
>         union acpi_object *obj;
>         acpi_status status;
>
> --
> 2.5.0
>



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] msi-wmi: remove unnecessary static in msi_wmi_notify() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-07-18 23:50 +0200
  Re: [PATCH] msi-wmi: remove unnecessary static in msi_wmi_notify() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-19 20:20 +0200

csiph-web