Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1692083

Re: [PATCH] ibm_rtl: remove unnecessary static in ibm_rtl_write()

Show all headers | View raw

On Wed, Jul 19, 2017 at 1:01 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Remove unnecessary static on local variable cmd_port_val. Such variable
> is initialized before being used, on every execution path throughout
> the function. The static has no benefit and, removing it reduces the
> object file size.
>
> This issue was detected using Coccinelle and the following semantic patch:
> https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci
>
> In the following log you can see a difference in the object file size.
> This log is the output of the size command, before and after the code
> change:
>
> before:
>    text    data     bss     dec     hex filename
>    3932 3440     512    7884    1ecc drivers/platform/x86/ibm_rtl.o
>
> after:
>    text    data     bss     dec     hex filename
>    3887    3384     448    7719    1e27 drivers/platform/x86/ibm_rtl.o
>

Pushed to testing, thanks,

> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/platform/x86/ibm_rtl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/ibm_rtl.c b/drivers/platform/x86/ibm_rtl.c
> index c62e5e1..610ac83 100644
> --- a/drivers/platform/x86/ibm_rtl.c
> +++ b/drivers/platform/x86/ibm_rtl.c
> @@ -103,7 +103,7 @@ static void rtl_port_unmap(void __iomem *addr)
>  static int ibm_rtl_write(u8 value)
>  {
>         int ret = 0, count = 0;
> -       static u32 cmd_port_val;
> +       u32 cmd_port_val;
>
>         RTL_DEBUG("%s(%d)\n", __func__, value);
>
> --
> 2.5.0
>



-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ibm_rtl: remove unnecessary static in ibm_rtl_write() "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-07-19 00:10 +0200
  Re: [PATCH] ibm_rtl: remove unnecessary static in ibm_rtl_write() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-07-19 20:20 +0200

csiph-web