Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1689891

Re: [RFC PATCH v12 4/4] LRNG - enable compile

From Stephan Müller <smueller@chronox.de>
Newsgroups linux.kernel
Subject Re: [RFC PATCH v12 4/4] LRNG - enable compile
Date 2017-07-18 11:00 +0200
Message-ID <u4wwj-9E-31@gated-at.bofh.it> (permalink)
References <u4vTz-8ne-3@gated-at.bofh.it> <u4vTA-8ne-17@gated-at.bofh.it> <u4wwi-9E-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Am Dienstag, 18. Juli 2017, 10:51:41 CEST schrieb Arnd Bergmann:

Hi Arnd,

> On Tue, Jul 18, 2017 at 9:59 AM, Stephan Müller <smueller@chronox.de> wrote:
> > Add LRNG compilation support.
> > 
> > diff --git a/drivers/char/Makefile b/drivers/char/Makefile
> > index 53e3372..87e06ec 100644
> > --- a/drivers/char/Makefile
> > +++ b/drivers/char/Makefile
> > @@ -2,7 +2,15 @@
> > 
> >  # Makefile for the kernel character device drivers.
> >  #
> > 
> > -obj-y                          += mem.o random.o
> > +obj-y                          += mem.o
> > +
> > +ifeq ($(CONFIG_LRNG),y)
> > +  obj-$(CONFIG_LRNG)           += lrng.o
> > +  lrng-y                       += lrng_base.o lrng_chacha20.o
> > +else
> > +  obj-y                                += random.o
> > +endif
> 
> I think you can write the same in a more readable way without the
> intermediate object:
> 
> ifdef CONFIG_LRNG
>   obj-y                       += lrng_base.o lrng_chacha20.o
> else
>   obj-y                       += random.o
> endif

Thank you for the hint, it will be included.
> 
>       Arnd


Ciao
Stephan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v12 0/4] /dev/random - a new approach Stephan Müller <smueller@chronox.de> - 2017-07-18 10:20 +0200
  [RFC PATCH v12 4/4] LRNG - enable compile Stephan Müller <smueller@chronox.de> - 2017-07-18 10:20 +0200
    Re: [RFC PATCH v12 4/4] LRNG - enable compile Arnd Bergmann <arnd@arndb.de> - 2017-07-18 11:00 +0200
      Re: [RFC PATCH v12 4/4] LRNG - enable compile Stephan Müller <smueller@chronox.de> - 2017-07-18 11:00 +0200
  Re: [RFC PATCH v12 3/4] Linux Random Number Generator Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-18 10:40 +0200
    Re: [RFC PATCH v12 3/4] Linux Random Number Generator Stephan Müller <smueller@chronox.de> - 2017-07-18 10:50 +0200
      Re: [RFC PATCH v12 3/4] Linux Random Number Generator Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-18 11:00 +0200
        Re: [RFC PATCH v12 3/4] Linux Random Number Generator Stephan Müller <smueller@chronox.de> - 2017-07-18 16:40 +0200
          Re: [RFC PATCH v12 3/4] Linux Random Number Generator Theodore Ts'o <tytso@mit.edu> - 2017-07-18 23:10 +0200
            Re: [RFC PATCH v12 3/4] Linux Random Number Generator Sandy Harris <sandyinchina@gmail.com> - 2017-07-19 03:10 +0200
              Re: [RFC PATCH v12 3/4] Linux Random Number Generator Theodore Ts'o <tytso@mit.edu> - 2017-07-19 04:00 +0200
                Re: [RFC PATCH v12 3/4] Linux Random Number Generator Stephan Müller <smueller@chronox.de> - 2017-07-19 08:30 +0200
                Re: [RFC PATCH v12 3/4] Linux Random Number Generator Pavel Machek <pavel@ucw.cz> - 2017-07-30 12:50 +0200
              Re: [RFC PATCH v12 3/4] Linux Random Number Generator Sandy Harris <sandyinchina@gmail.com> - 2017-07-23 20:10 +0200
                Re: [RFC PATCH v12 3/4] Linux Random Number Generator Theodore Ts'o <tytso@mit.edu> - 2017-07-23 23:50 +0200
            Re: [RFC PATCH v12 3/4] Linux Random Number Generator Stephan Müller <smueller@chronox.de> - 2017-07-19 08:30 +0200
              Re: [RFC PATCH v12 3/4] Linux Random Number Generator Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-19 08:40 +0200
              Re: [RFC PATCH v12 3/4] Linux Random Number Generator Theodore Ts'o <tytso@mit.edu> - 2017-07-19 19:30 +0200
                Re: [RFC PATCH v12 3/4] Linux Random Number Generator Stephan Müller <smueller@chronox.de> - 2017-07-20 21:10 +0200
                Re: [RFC PATCH v12 3/4] Linux Random Number Generator Theodore Ts'o <tytso@mit.edu> - 2017-07-21 05:10 +0200
                Re: [RFC PATCH v12 3/4] Linux Random Number Generator Stephan Müller <smueller@chronox.de> - 2017-07-21 11:00 +0200
                Re: [RFC PATCH v12 3/4] Linux Random Number Generator Stephan Müller <smueller@chronox.de> - 2017-07-21 17:20 +0200
                Re: [RFC PATCH v12 3/4] Linux Random Number Generator Arnd Bergmann <arnd@arndb.de> - 2017-07-21 17:20 +0200
      Re: [RFC PATCH v12 3/4] Linux Random Number Generator Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-07-18 11:00 +0200

csiph-web