Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early write

From	jeffy <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early write
Date	2017-07-18 08:10 +0200
Message-ID	<u4tRM-7a0-27@gated-at.bofh.it> (permalink)
References	<u4ssF-6bP-3@gated-at.bofh.it> <u4ssF-6bP-7@gated-at.bofh.it> <u4sVH-6Bk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Greg,

On 07/18/2017 01:08 PM, Greg KH wrote:
> On Tue, Jul 18, 2017 at 12:29:59PM +0800, Jeffy Chen wrote:
>> The earlycon would be alive outside the init code in these cases:
>> 1/ we have keep_bootcon in cmdline.
>> 2/ we don't have a real console to switch to.
>>
>> So remove the __init marking to avoid invalid memory access.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>
> I can't apply "RFC" patches.  If you have tested and found this series
> to be correct, can you resend it without that on the patch?
oh, sorry, i'll resend it :)

but i'm still not sure how to fix other hang cases(mentioned in the 
cover-letter, earlycon's required clks/pm domain been disabled by ignore 
unused initcalls or serial console driver's runtime suspend).
>
> thanks,
>
> greg k-h
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/5] serial: arc: Remove __init marking from early write Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-07-18 06:40 +0200
  Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early  write Greg KH <gregkh@linuxfoundation.org> - 2017-07-18 07:10 +0200
    Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early  write jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 08:10 +0200

csiph-web