[RFC PATCH 1/5] serial: arc: Remove __init marking from early write

From	Jeffy Chen <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	[RFC PATCH 1/5] serial: arc: Remove __init marking from early write
Date	2017-07-18 06:40 +0200
Message-ID	<u4ssF-6bP-7@gated-at.bofh.it> (permalink)
References	<u4ssF-6bP-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The earlycon would be alive outside the init code in these cases:
1/ we have keep_bootcon in cmdline.
2/ we don't have a real console to switch to.

So remove the __init marking to avoid invalid memory access.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 drivers/tty/serial/arc_uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/arc_uart.c b/drivers/tty/serial/arc_uart.c
index 5ac06fc..77fe306 100644
--- a/drivers/tty/serial/arc_uart.c
+++ b/drivers/tty/serial/arc_uart.c
@@ -549,8 +549,8 @@ static struct console arc_console = {
 	.data	= &arc_uart_driver
 };
 
-static __init void arc_early_serial_write(struct console *con, const char *s,
-					  unsigned int n)
+static void arc_early_serial_write(struct console *con, const char *s,
+				   unsigned int n)
 {
 	struct earlycon_device *dev = con->data;
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/5] serial: arc: Remove __init marking from early write Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-07-18 06:40 +0200
  Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early  write Greg KH <gregkh@linuxfoundation.org> - 2017-07-18 07:10 +0200
    Re: [RFC PATCH 1/5] serial: arc: Remove __init marking from early  write jeffy <jeffy.chen@rock-chips.com> - 2017-07-18 08:10 +0200

csiph-web