Re: [PATCH v2] kbuild: trivial cleanups on the comments

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] kbuild: trivial cleanups on the comments
Date	2017-07-17 13:20 +0200
Message-ID	<u4ced-4iB-3@gated-at.bofh.it> (permalink)
References	<u2ILg-3SK-9@gated-at.bofh.it> <u3OEV-62q-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Cao,


2017-07-16 19:12 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
> index 61f87a9..f0a4ada 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -85,8 +85,8 @@ TMPOUT := $(if $(KBUILD_EXTMOD),$(firstword $(KBUILD_EXTMOD))/)
>
>  # try-run
>  # Usage: option = $(call try-run, $(CC)...-o "$$TMP",option-ok,otherwise)
> -# Exit code chooses option. "$$TMP" is can be used as temporary file and
> -# is automatically cleaned up.
> +# Exit code chooses option. "$$TMP" serves as temporary file and is
> +# automatically cleaned up.


I am not a native speaker, but I think "file" is countable.

Maybe, is "as a temporary file" even better?




> diff --git a/scripts/basic/Makefile b/scripts/basic/Makefile
> index ec10d93..edd983f 100644
> --- a/scripts/basic/Makefile
> +++ b/scripts/basic/Makefile
> @@ -1,5 +1,5 @@
>  ###
> -# Makefile.basic lists the most basic programs used during the build process.
> +# scripts/basic/Makefile lists the most basic programs used during the build process.

This change is correct, but this line will exceed 80 cols limit.

Wrap the lines, or reword like "This Makefile lists ..."

Either will do.



>  # The programs listed herein are what are needed to do the basic stuff,
>  # such as fix file dependencies.
>  # This initial step is needed to avoid files to be recompiled






-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kbuild: trivial cleanup on the comments Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-07-13 11:40 +0200
  [PATCH v2] kbuild: trivial cleanups on the comments Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-07-16 12:10 +0200
    Re: [PATCH v2] kbuild: trivial cleanups on the comments Randy Dunlap <rdunlap@infradead.org> - 2017-07-16 19:00 +0200
    Re: [PATCH v2] kbuild: trivial cleanups on the comments Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-17 13:20 +0200

csiph-web