Re: [PATCH v2] kbuild: trivial cleanups on the comments

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] kbuild: trivial cleanups on the comments
Date	Mon, 17 Jul 2017 13:20:01 +0200
Message-ID	<u4ced-4iB-3@gated-at.bofh.it> (permalink)
References	<u2ILg-3SK-9@gated-at.bofh.it> <u3OEV-62q-3@gated-at.bofh.it>
Dkim-Filter	OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com v6HBDGw2024837
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1500289997; bh=TVO/u28Jlrl5dsLwY8Hwh+jr80yv2oJdbrhtyLmt9CE=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=I2JeFmqkbzKHPySuuqZ2kOd8nLHYyHjlZ8X7OQgvtOIrG+MdANHLZ0b49P9rpt/ra drLCqhLm5PWD3UJDeX7CagCbKqsccypE1p806HzZyz+6jIP3qiz/uZ5FXrPYJWFqV8 ay31cru9zDUZ3vR1VgvjASy9kDoLzRyxiejV5iQSxHdDMyM2HTLFuHkbaKxk9mE9OT Ej189WWzS6t7BLo3R8l8kAw3tt4n7lcJm5wrNZBqYiFPUS4sPFHGRWeJPiwdP7JOCd Rd3LnXcGOhjOX3VucHPp8tctJ5d3RWrEIzVgvYf/QxfxwGYGr5HSE6VQlrBLnPIGpQ vuAn1L5YMQygg==
X-Nifty-Srcip	[209.85.161.173]
X-Gm-Message-State	AIVw111NkaeE2juqpO0D2UPNWsU62Sr1oYpSuN/Kgy9fTHSgobmGgjcb YNAIZpo8REjN425oYMDcTSnEmpmlFw==
X-Received	by 10.129.89.5 with SMTP id n5mr15538871ywb.343.1500289996132; Mon, 17 Jul 2017 04:13:16 -0700 (PDT)
MIME-Version	1.0
X-Gmail-Original-Message-ID	<CAK7LNAQiOSdMYqV+U_155iNaL-cBWn99kLu8uczW9pKR-Gwkww@mail.gmail.com>
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	53
Organization	linux.* mail to news gateway
X-Original-Cc	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, Michal Marek <mmarek@suse.com>
X-Original-Date	Mon, 17 Jul 2017 20:13:15 +0900
X-Original-Message-ID	<CAK7LNAQiOSdMYqV+U_155iNaL-cBWn99kLu8uczW9pKR-Gwkww@mail.gmail.com>
X-Original-References	<1499938671-13376-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1500199925-5542-1-git-send-email-caoj.fnst@cn.fujitsu.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1688933

Show key headers only | View raw

Hi Cao,


2017-07-16 19:12 GMT+09:00 Cao jin <caoj.fnst@cn.fujitsu.com>:
> index 61f87a9..f0a4ada 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -85,8 +85,8 @@ TMPOUT := $(if $(KBUILD_EXTMOD),$(firstword $(KBUILD_EXTMOD))/)
>
>  # try-run
>  # Usage: option = $(call try-run, $(CC)...-o "$$TMP",option-ok,otherwise)
> -# Exit code chooses option. "$$TMP" is can be used as temporary file and
> -# is automatically cleaned up.
> +# Exit code chooses option. "$$TMP" serves as temporary file and is
> +# automatically cleaned up.


I am not a native speaker, but I think "file" is countable.

Maybe, is "as a temporary file" even better?




> diff --git a/scripts/basic/Makefile b/scripts/basic/Makefile
> index ec10d93..edd983f 100644
> --- a/scripts/basic/Makefile
> +++ b/scripts/basic/Makefile
> @@ -1,5 +1,5 @@
>  ###
> -# Makefile.basic lists the most basic programs used during the build process.
> +# scripts/basic/Makefile lists the most basic programs used during the build process.

This change is correct, but this line will exceed 80 cols limit.

Wrap the lines, or reword like "This Makefile lists ..."

Either will do.



>  # The programs listed herein are what are needed to do the basic stuff,
>  # such as fix file dependencies.
>  # This initial step is needed to avoid files to be recompiled






-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kbuild: trivial cleanup on the comments Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-07-13 11:40 +0200
  [PATCH v2] kbuild: trivial cleanups on the comments Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-07-16 12:10 +0200
    Re: [PATCH v2] kbuild: trivial cleanups on the comments Randy Dunlap <rdunlap@infradead.org> - 2017-07-16 19:00 +0200
    Re: [PATCH v2] kbuild: trivial cleanups on the comments Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-07-17 13:20 +0200

csiph-web