Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1690952
| From | Keerthy <j-keerthy@ti.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes |
| Date | 2017-07-19 06:10 +0200 |
| Message-ID | <u4Otb-3eF-5@gated-at.bofh.it> (permalink) |
| References | <u4yoq-1lh-25@gated-at.bofh.it> <u4yor-1lh-55@gated-at.bofh.it> <u4Gch-6nx-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wednesday 19 July 2017 12:43 AM, Suman Anna wrote:
> Hi Keerthy,
>
> On 07/18/2017 05:57 AM, Keerthy wrote:
>> keystone-k2g has 2 instances of gpio. The first one has all the 144 GPIOs
>
> Please use 66AK2G for keystone-k2g.
Okay
>
>> functional( 9 banks with 16 gpios = 144). The second instance has
>> only the GPIO0:GPIO67 functional and rest are marked reserved.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>> arch/arm/boot/dts/keystone-k2g.dtsi | 42 +++++++++++++++++++++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
>> index bf4d1fa..58ac3db 100644
>> --- a/arch/arm/boot/dts/keystone-k2g.dtsi
>> +++ b/arch/arm/boot/dts/keystone-k2g.dtsi
>> @@ -15,6 +15,7 @@
>>
>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>> #include <dt-bindings/pinctrl/keystone.h>
>> +#include <dt-bindings/gpio/gpio.h>
>>
>> / {
>> compatible = "ti,k2g","ti,keystone";
>> @@ -168,5 +169,46 @@
>> #reset-cells = <2>;
>> };
>> };
>> +
>> + gpio0: gpio@2603000 {
>> + compatible = "ti,keystone-k2g-gpio";
>> + reg = <0x02603000 0x100>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> +
>> + interrupts = <GIC_SPI 432 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 433 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 434 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 435 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 436 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 437 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 438 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 439 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 440 IRQ_TYPE_EDGE_RISING>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + ti,ngpio = <144>;
>> + ti,davinci-gpio-unbanked = <0>;
>> + clocks = <&k2g_clks 0x001b 0x0>;
>> + clock-names = "gpio";
>
> I don't see the clocks and clock-names documented in the binding.
> Looking at davinci_gpio_irq_setup(), these are required, and a specific
> clock name is what the driver is looking for. And you have different
> semantics for this on K2G and non-K2G SoCs. Davinci platforms are using
> non-DT clocks, so their DT nodes didn't have them.
I will document the same.
>
> regards
> Suman
>
>> + };
>> +
>> + gpio1: gpio@260a000 {
>> + compatible = "ti,keystone-k2g-gpio";
>> + reg = <0x0260a000 0x100>;
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupts = <GIC_SPI 442 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 443 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 444 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 445 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 446 IRQ_TYPE_EDGE_RISING>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + ti,ngpio = <68>;
>> + ti,davinci-gpio-unbanked = <0>;
>> + clocks = <&k2g_clks 0x001c 0x0>;
>> + clock-names = "gpio";
>> + };
>> };
>> };
>>
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] gpio: davinci: Add keystone-k2g support and few clean ups Keerthy <j-keerthy@ti.com> - 2017-07-18 13:00 +0200
[PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy <j-keerthy@ti.com> - 2017-07-18 13:00 +0200
Re: [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Suman Anna <s-anna@ti.com> - 2017-07-18 21:20 +0200
Re: [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy <j-keerthy@ti.com> - 2017-07-19 06:10 +0200
[PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Keerthy <j-keerthy@ti.com> - 2017-07-18 13:00 +0200
Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Suman Anna <s-anna@ti.com> - 2017-07-18 19:00 +0200
Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Keerthy <j-keerthy@ti.com> - 2017-07-18 19:50 +0200
Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Johan Hovold <johan@kernel.org> - 2017-07-19 11:40 +0200
Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Keerthy <j-keerthy@ti.com> - 2017-07-19 12:00 +0200
[PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-18 13:00 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Suman Anna <s-anna@ti.com> - 2017-07-18 19:00 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-18 19:50 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Johan Hovold <johan@kernel.org> - 2017-07-19 13:20 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-20 08:50 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-20 11:20 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Johan Hovold <johan@kernel.org> - 2017-07-20 12:00 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-20 12:10 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Johan Hovold <johan@kernel.org> - 2017-07-20 12:10 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-20 12:20 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-20 23:40 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-21 06:00 +0200
Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Johan Hovold <johan@kernel.org> - 2017-07-21 09:50 +0200
[PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc Keerthy <j-keerthy@ti.com> - 2017-07-18 13:10 +0200
Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc Sekhar Nori <nsekhar@ti.com> - 2017-07-18 13:40 +0200
Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc Keerthy <j-keerthy@ti.com> - 2017-07-18 19:50 +0200
Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc Rob Herring <robh@kernel.org> - 2017-07-24 20:30 +0200
Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc Keerthy <j-keerthy@ti.com> - 2017-07-25 05:30 +0200
csiph-web