Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1691259

Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data

Show all headers | View raw

On Wednesday 19 July 2017 03:07 PM, Johan Hovold wrote:
> On Tue, Jul 18, 2017 at 04:27:13PM +0530, Keerthy wrote:
>> Use the devm version of gpiochip_add_data and pass on the
>> return value. Reset the static variables to 0 before returning.
> 
> You need to describe not just what you do, but also why you it. In this
> case, your fixing memory leaks and the gpio chip being left registered
> if this driver is unbound.

Sure i can add more description as mentioned above.

> 
> Johan
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] gpio: davinci: Add keystone-k2g support and few clean ups Keerthy <j-keerthy@ti.com> - 2017-07-18 13:00 +0200
  [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy <j-keerthy@ti.com> - 2017-07-18 13:00 +0200
    Re: [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Suman Anna <s-anna@ti.com> - 2017-07-18 21:20 +0200
      Re: [PATCH 4/4] ARM: dts: keystone-k2g-evm: Add gpio nodes Keerthy <j-keerthy@ti.com> - 2017-07-19 06:10 +0200
  [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data Keerthy <j-keerthy@ti.com> - 2017-07-18 13:00 +0200
    Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of  gpiochip_add_data Suman Anna <s-anna@ti.com> - 2017-07-18 19:00 +0200
      Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of  gpiochip_add_data Keerthy <j-keerthy@ti.com> - 2017-07-18 19:50 +0200
    Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place  of gpiochip_add_data Johan Hovold <johan@kernel.org> - 2017-07-19 11:40 +0200
      Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of  gpiochip_add_data Keerthy <j-keerthy@ti.com> - 2017-07-19 12:00 +0200
  [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-18 13:00 +0200
    Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Suman Anna <s-anna@ti.com> - 2017-07-18 19:00 +0200
      Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-18 19:50 +0200
    Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Johan Hovold <johan@kernel.org> - 2017-07-19 13:20 +0200
      Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-20 08:50 +0200
        Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-20 11:20 +0200
          Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Johan Hovold <johan@kernel.org> - 2017-07-20 12:00 +0200
            Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-20 12:10 +0200
              Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Johan Hovold <johan@kernel.org> - 2017-07-20 12:10 +0200
                Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-20 12:20 +0200
                Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Grygorii Strashko <grygorii.strashko@ti.com> - 2017-07-20 23:40 +0200
                Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Keerthy <j-keerthy@ti.com> - 2017-07-21 06:00 +0200
                Re: [PATCH 2/4] gpio: davinci: Handle the return value of  davinci_gpio_irq_setup function Johan Hovold <johan@kernel.org> - 2017-07-21 09:50 +0200
  [PATCH 3/4] gpio: davinci: Add a separate compatible for keystone-k2g soc Keerthy <j-keerthy@ti.com> - 2017-07-18 13:10 +0200
    Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for  keystone-k2g soc Sekhar Nori <nsekhar@ti.com> - 2017-07-18 13:40 +0200
      Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for  keystone-k2g soc Keerthy <j-keerthy@ti.com> - 2017-07-18 19:50 +0200
    Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for  keystone-k2g soc Rob Herring <robh@kernel.org> - 2017-07-24 20:30 +0200
      Re: [PATCH 3/4] gpio: davinci: Add a separate compatible for  keystone-k2g soc Keerthy <j-keerthy@ti.com> - 2017-07-25 05:30 +0200

csiph-web