Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support
Date	2017-07-19 06:10 +0200
Message-ID	<u4Otb-3eF-3@gated-at.bofh.it> (permalink)
References	<tXU0F-7Ql-7@gated-at.bofh.it> <u4Do5-4CZ-11@gated-at.bofh.it> <u4DxL-4G9-3@gated-at.bofh.it> <u4DR8-4Ny-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 18, 2017 at 10:17:06PM +0530, Vinod Koul wrote:
> On Tue, Jul 18, 2017 at 12:26:14PM -0400, Sinan Kaya wrote:
> > Hi Vinod,
> > 
> > On 7/18/2017 12:19 PM, Vinod Koul wrote:
> > > On Thu, Jun 29, 2017 at 10:30:57PM -0400, Sinan Kaya wrote:
> > > 
> > >> @@ -410,7 +410,40 @@ static int hidma_alloc_chan_resources(struct dma_chan *dmach)
> > >>  		return NULL;
> > >>  
> > >>  	hidma_ll_set_transfer_params(mdma->lldev, mdesc->tre_ch,
> > >> -				     src, dest, len, flags);
> > >> +				     src, dest, len, flags,
> > >> +				     HIDMA_TRE_MEMCPY);
> > >> +
> > >> +	/* Place descriptor in prepared list */
> > >> +	spin_lock_irqsave(&mchan->lock, irqflags);
> > >> +	list_add_tail(&mdesc->node, &mchan->prepared);
> > >> +	spin_unlock_irqrestore(&mchan->lock, irqflags);
> > > 
> > > This change looks suspicious, cna you clarify the need to do this?
> > > 
> > > 
> > 
> > Diff looks weird for some reason. I noticed that too.
> > 
> > I just added HIDMA_TRE_MEMCPY parameter to hidma_ll_set_transfer_params() function call
> > from hidma_prep_dma_memcpy() and created a new hidma_prep_dma_memset() function very
> > similar to memcpy with HIDMA_TRE_MEMSET call difference.
> > 
> > My suggestion is to use kdiff or another visual tool to look at the change.
> 
> ah fine then, let me take a look at it again with rested pair of eyes in the
> morn :)

Checked the context is fine, so

Applied, thanks

-- 
~Vinod

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Vinod Koul <vinod.koul@intel.com> - 2017-07-18 18:20 +0200
  Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Sinan Kaya <okaya@codeaurora.org> - 2017-07-18 18:30 +0200
    Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Vinod Koul <vinod.koul@intel.com> - 2017-07-18 18:50 +0200
      Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Vinod Koul <vinod.koul@intel.com> - 2017-07-19 06:10 +0200

csiph-web