Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support

From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support
Date	2017-07-18 18:20 +0200
Message-ID	<u4Do5-4CZ-11@gated-at.bofh.it> (permalink)
References	<tXU0F-7Ql-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 29, 2017 at 10:30:57PM -0400, Sinan Kaya wrote:

> @@ -410,7 +410,40 @@ static int hidma_alloc_chan_resources(struct dma_chan *dmach)
>  		return NULL;
>  
>  	hidma_ll_set_transfer_params(mdma->lldev, mdesc->tre_ch,
> -				     src, dest, len, flags);
> +				     src, dest, len, flags,
> +				     HIDMA_TRE_MEMCPY);
> +
> +	/* Place descriptor in prepared list */
> +	spin_lock_irqsave(&mchan->lock, irqflags);
> +	list_add_tail(&mdesc->node, &mchan->prepared);
> +	spin_unlock_irqrestore(&mchan->lock, irqflags);

This change looks suspicious, cna you clarify the need to do this?


-- 
~Vinod

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Vinod Koul <vinod.koul@intel.com> - 2017-07-18 18:20 +0200
  Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Sinan Kaya <okaya@codeaurora.org> - 2017-07-18 18:30 +0200
    Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Vinod Koul <vinod.koul@intel.com> - 2017-07-18 18:50 +0200
      Re: [PATCH V3 1/2] dmaengine: qcom_hidma: introduce memset support Vinod Koul <vinod.koul@intel.com> - 2017-07-19 06:10 +0200

csiph-web