Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1688616

Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices

Show all headers | View raw

Hi Laurent,

2017-07-17 10:28 GMT+08:00 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> Hi Jacob,
>
> On Sunday 16 Jul 2017 12:23:02 Jacob Chen wrote:
>> 2017-07-15 17:16 GMT+08:00 Laurent Pinchart:
>> > On Saturday 15 Jul 2017 14:58:39 Jacob Chen wrote:
>> >> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
>> >> ---
>> >>
>> >>  arch/arm/boot/dts/rk3288-evb.dtsi                 | 4 ++++
>> >>  arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 4 ++++
>> >>  arch/arm/boot/dts/rk3288-firefly.dtsi             | 4 ++++
>> >>  arch/arm/boot/dts/rk3288-miqi.dts                 | 4 ++++
>> >>  arch/arm/boot/dts/rk3288-popmetal.dts             | 4 ++++
>> >>  arch/arm/boot/dts/rk3288-tinker.dts               | 4 ++++
>> >
>> > Some boards are missing from this list (Fennec, Phycore, ...) What
>> > criteria have you used to decide on which ones to enable the RGA ? That
>> > should be explained in the commit message.
>>
>> Ok.
>>
>> I just enable the boards i have tested, because i can't make sure it
>> won't break the other board because of clocks or power-domains.
>
> Given the clocks and power domains shouldn't be board-specific, would it make
> sense to try and get the change tested on the remaining boards ? You could

Not all drivers have handle power domains and clocks appropriately, It
may triggers bugs,
but since it's a V4l2 driver not DRM driver, i will enable it for all
rk3288 boards.
(DRM device will try to probe in very eraly stage and update
clocks/power-domains...)


> then enable the device in the SoC .dtsi file, which would be much simpler.
>

We have many different version RGA drivers in rockchip downstream kernel.
To keep consistent, i didn't enable it in .dtsi.


>> >>  6 files changed, 24 insertions(+)
>
> --
> Regards,
>
> Laurent Pinchart
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] Add Rockchip RGA V4l2 support Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
  [PATCH v2 1/6] [media] v4l: add blend modes controls Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
    Re: [PATCH v2 1/6] [media] v4l: add blend modes controls Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-15 11:40 +0200
  [PATCH v2 3/6] ARM: dts: rockchip: add RGA device node for RK3288 Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
    Re: [PATCH v2 3/6] ARM: dts: rockchip: add RGA device node for RK3288 Heiko Stuebner <heiko@sntech.de> - 2017-07-15 10:20 +0200
  [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
    Re: [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-15 11:30 +0200
      Re: [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Heiko Stuebner <heiko@sntech.de> - 2017-07-16 18:10 +0200
        Re: [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-17 04:30 +0200
  [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
    Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-15 11:20 +0200
      Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Jacob Chen <jacobchen110@gmail.com> - 2017-07-16 06:30 +0200
        Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-17 04:30 +0200
          Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Jacob Chen <jacobchen110@gmail.com> - 2017-07-17 05:10 +0200
  [PATCH v2 4/6] ARM: dts: rockchip: add RGA device node for RK3399 Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:10 +0200
  Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-15 11:50 +0200
    Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Personnel <nicolas@ndufresne.ca> - 2017-07-15 18:50 +0200
      Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Jacob Chen <jacobchen110@gmail.com> - 2017-07-16 06:20 +0200
        Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-17 04:50 +0200
          Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Jacob Chen <jacobchen110@gmail.com> - 2017-07-17 05:50 +0200
      Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-17 04:40 +0200
        Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Nicolas Dufresne <nicolas@ndufresne.ca> - 2017-07-17 16:50 +0200

csiph-web