Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1687905

Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support

Show all headers | View raw

Hi Jacob,

Thank you for the patch.

On Saturday 15 Jul 2017 14:58:36 Jacob Chen wrote:
> Rockchip RGA is a separate 2D raster graphic acceleration unit. It
> accelerates 2D graphics operations, such as point/line drawing, image
> scaling, rotation, BitBLT, alpha blending and image blur/sharpness.
> 
> The drvier is mostly based on s5p-g2d v4l2 m2m driver.
> And supports various operations from the rendering pipeline.
>  - copy
>  - fast solid color fill
>  - rotation
>  - flip
>  - alpha blending

I notice that you don't support the drawing operations. How do you plan to 
support them later through the V4L2 M2M API ? I hate stating the obvious, but 
wouldn't the DRM API be better fit for a graphic accelerator ?

Additionally, V4L2 M2M has one source and one destination. How do you 
implement alpha blending in that case, which by definition requires at least 
two sources ?

> The code in rga-hw.c is used to configure regs accroding to operations.
> 
> The code in rga-buf.c is used to create private mmu table for RGA.
> The tables is stored in a list, and be removed when buffer is cleanup.

Looking at the implementation it seems to be a scatter-gather list, not an 
MMU. Is that right ? Does the hardware documentation refer to it as an MMU ?

> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
> ---
>  drivers/media/platform/Kconfig                |  11 +
>  drivers/media/platform/Makefile               |   2 +
>  drivers/media/platform/rockchip-rga/Makefile  |   3 +
>  drivers/media/platform/rockchip-rga/rga-buf.c | 122 ++++
>  drivers/media/platform/rockchip-rga/rga-hw.c  | 652 ++++++++++++++++++
>  drivers/media/platform/rockchip-rga/rga-hw.h  | 437 ++++++++++++
>  drivers/media/platform/rockchip-rga/rga.c     | 958 +++++++++++++++++++++++
>  drivers/media/platform/rockchip-rga/rga.h     | 111 +++
>  8 files changed, 2296 insertions(+)
>  create mode 100644 drivers/media/platform/rockchip-rga/Makefile
>  create mode 100644 drivers/media/platform/rockchip-rga/rga-buf.c
>  create mode 100644 drivers/media/platform/rockchip-rga/rga-hw.c
>  create mode 100644 drivers/media/platform/rockchip-rga/rga-hw.h
>  create mode 100644 drivers/media/platform/rockchip-rga/rga.c
>  create mode 100644 drivers/media/platform/rockchip-rga/rga.h

-- 
Regards,

Laurent Pinchart

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] Add Rockchip RGA V4l2 support Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
  [PATCH v2 1/6] [media] v4l: add blend modes controls Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
    Re: [PATCH v2 1/6] [media] v4l: add blend modes controls Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-15 11:40 +0200
  [PATCH v2 3/6] ARM: dts: rockchip: add RGA device node for RK3288 Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
    Re: [PATCH v2 3/6] ARM: dts: rockchip: add RGA device node for RK3288 Heiko Stuebner <heiko@sntech.de> - 2017-07-15 10:20 +0200
  [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
    Re: [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-15 11:30 +0200
      Re: [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Heiko Stuebner <heiko@sntech.de> - 2017-07-16 18:10 +0200
        Re: [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-17 04:30 +0200
  [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:00 +0200
    Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-15 11:20 +0200
      Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Jacob Chen <jacobchen110@gmail.com> - 2017-07-16 06:30 +0200
        Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-17 04:30 +0200
          Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Jacob Chen <jacobchen110@gmail.com> - 2017-07-17 05:10 +0200
  [PATCH v2 4/6] ARM: dts: rockchip: add RGA device node for RK3399 Jacob Chen <jacob-chen@iotwrt.com> - 2017-07-15 09:10 +0200
  Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-15 11:50 +0200
    Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Personnel <nicolas@ndufresne.ca> - 2017-07-15 18:50 +0200
      Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Jacob Chen <jacobchen110@gmail.com> - 2017-07-16 06:20 +0200
        Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-17 04:50 +0200
          Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Jacob Chen <jacobchen110@gmail.com> - 2017-07-17 05:50 +0200
      Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2017-07-17 04:40 +0200
        Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Nicolas Dufresne <nicolas@ndufresne.ca> - 2017-07-17 16:50 +0200

csiph-web