Re: [PATCH v5 2/4] sched/deadline: Change return value of cpudl_find()

From	Juri Lelli <juri.lelli@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 2/4] sched/deadline: Change return value of cpudl_find()
Date	2017-07-12 15:30 +0200
Message-ID	<u2pSj-ja-29@gated-at.bofh.it> (permalink)
References	<tK7qO-5fE-9@gated-at.bofh.it> <tK7qO-5fE-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 23/05/17 11:00, Byungchul Park wrote:
> Currently cpudl_find() returns the best cpu that means it has the
> maximum dl, however, the value is already kept in later_mask and the
> return value is not referred directly any more.
> 
> Now, it's enough to return whether CPUs were found or not, like rt.
> 

I'd reword as

cpudl_find() users are only interested in knowing if suitable CPU(s)
were found or not (and then they look at later_mask to know which).

Change cpudl_find() return type accordingly.

> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
>  kernel/sched/cpudeadline.c | 26 +++++++++++++-------------
>  kernel/sched/deadline.c    |  6 +++---
>  2 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c
> index fba235c..7408cbe 100644
> --- a/kernel/sched/cpudeadline.c
> +++ b/kernel/sched/cpudeadline.c
> @@ -119,29 +119,29 @@ static inline int cpudl_maximum(struct cpudl *cp)
>   * @p: the task
>   * @later_mask: a mask to fill in with the selected CPUs (or NULL)
>   *
> - * Returns: int - best CPU (heap maximum if suitable)
> + * Returns: (int)bool - CPUs were found

Why not simply bool?

Thanks,

- Juri

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 2/4] sched/deadline: Change return value of  cpudl_find() Juri Lelli <juri.lelli@arm.com> - 2017-07-12 15:30 +0200
  Re: [PATCH v5 2/4] sched/deadline: Change return value of  cpudl_find() Byungchul Park <byungchul.park@lge.com> - 2017-07-13 03:30 +0200

csiph-web