Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1685776

Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient
Date 2017-07-12 15:30 +0200
Message-ID <u2pSi-ja-21@gated-at.bofh.it> (permalink)
References (1 earlier) <u20qS-Yv-3@gated-at.bofh.it> <u24b8-3nP-31@gated-at.bofh.it> <u2i4p-3Lw-3@gated-at.bofh.it> <u2mhI-6sQ-15@gated-at.bofh.it> <u2mro-6xz-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 12, 2017 at 03:16:23PM +0530, Viresh Kumar wrote:

> No, I wasn't clear enough. Sorry about that. Lemme try again:
> 
> Suppose min freq is 500 MHz and Max is 2 GHz. The iowait-boost is
> set to 1 GHz right now (because of previous events with IOWAIT flag
> set), and sugov_set_iowait_boost() gets called again with IOWAIT flag,
> we boost the iowait-boost value to 2 GHz. We are in the rate_limit_us
> window right now, we return without changing the frequency.
> 
> If the next call into the schedutil governor happens due to normal
> util-update, flags will be passed as 0. With the current patch, we
> will bring iowait-boost back to 1 GHz (before updating the real
> frequency to 2 GHz) as the prev-iowait-boost boolean would be set.
> 
> And even if the task is periodically getting queued after IOWAIT,
> actual boosting may not happen at all in some cases.

Hmm, so you're worried about that ratelimit stuff? Shouldn't we fix that
independently -- IIRC Rafael proposed a max-filter over the window.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient Joel Fernandes <joelaf@google.com> - 2017-07-09 19:10 +0200
  Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Juri Lelli <juri.lelli@arm.com> - 2017-07-10 13:00 +0200
    Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient Joel Fernandes <joelaf@google.com> - 2017-07-11 07:20 +0200
      Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Juri Lelli <juri.lelli@arm.com> - 2017-07-11 09:20 +0200
        Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Juri Lelli <juri.lelli@arm.com> - 2017-07-11 16:40 +0200
        Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient Joel Fernandes <joelaf@google.com> - 2017-07-11 16:40 +0200
  Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-11 12:20 +0200
    Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Peter Zijlstra <peterz@infradead.org> - 2017-07-11 13:50 +0200
    Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient Joel Fernandes <joelaf@google.com> - 2017-07-11 16:20 +0200
    Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient Joel Fernandes <joelaf@google.com> - 2017-07-11 16:20 +0200
      Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-12 07:10 +0200
        Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Peter Zijlstra <peterz@infradead.org> - 2017-07-12 11:40 +0200
          Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-12 11:50 +0200
            Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Peter Zijlstra <peterz@infradead.org> - 2017-07-12 15:30 +0200
              Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-13 05:50 +0200
        Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient Joel Fernandes <joelaf@google.com> - 2017-07-13 04:10 +0200
          Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-13 05:40 +0200
            Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient Joel Fernandes <joelaf@google.com> - 2017-07-13 06:00 +0200
              Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-13 06:20 +0200
                Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy efficient Joel Fernandes <joelaf@google.com> - 2017-07-13 06:20 +0200
  Re: [PATCH RFC v4] cpufreq: schedutil: Make iowait boost more energy  efficient Peter Zijlstra <peterz@infradead.org> - 2017-07-11 13:50 +0200

csiph-web