Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1684786
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures. |
| Date | 2017-07-11 08:00 +0200 |
| Message-ID | <u1Wnf-6Mo-3@gated-at.bofh.it> (permalink) |
| References | <u1EgG-3Sw-17@gated-at.bofh.it> <u1Km7-7MA-25@gated-at.bofh.it> <u1Wdz-6Iv-5@gated-at.bofh.it> <u1Wdz-6Iv-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Joe, On Tuesday 11 July 2017 11:17 AM, Joe Perches wrote: > On Tue, 2017-07-11 at 11:11 +0530, Arvind Yadav wrote: >> Hi Joe, >> >> >> On Monday 10 July 2017 10:30 PM, Joe Perches wrote: >>> On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote: >>>> attribute_groups are not supposed to change at runtime. All functions >>>> working with attribute_groups provided by <linux/sysfs.h> work >>>> with const attribute_group. So mark the non-const structs as const. >>> I think it's good you are doing all of these. >>> >>> Instead of individually sending these patches, could you >>> please send a patch series for all of these attribute_group >>> patches with a cover letter at the same time? >>> >>> That could make it easier for a trivial maintainer to apply >>> all of these at once and not get some applied and others >>> ignored or dropped on the floor. >>> >> Once again, I will send all of patch together, But I have doubt. If it's >> having >> different maintainer. Example- 'net:' subsystem is having a different >> different >> maintainer. So do i need to add all the maintainer in single list. Which >> can confuse >> what patch is for what maintainer. Please suggest me. > Please send individual patches, one per maintainer/subsystem > as a series with a cover letter like: > > [PATCH 0/N] treewide: constify attribute_group structures > [PATCH 1/N] chelsio: cxgb3: constify attribute_group > [PATCH 2/N] chelsio: cxgb4: constify attribute_group > ... > [PATCH N/N] subsystem: constify attribute_group > Thank you, I will follow as per your suggestion. Regards, ~arvind
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: chelsio: cxgb3: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-10 12:40 +0200
Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures. Joe Perches <joe@perches.com> - 2017-07-10 19:10 +0200
Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures. Joe Perches <joe@perches.com> - 2017-07-11 07:50 +0200
Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 08:00 +0200
Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-11 07:50 +0200
csiph-web