Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1682056

Re: [PATCH 2/2] genirq: Use is_fwnode_irqchip() directly

From Ethan Zhao <ethan.kernel@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] genirq: Use is_fwnode_irqchip() directly
Date 2017-07-06 07:50 +0200
Message-ID <u07PP-eU-7@gated-at.bofh.it> (permalink)
References <u06TL-7T5-7@gated-at.bofh.it> <u06TL-7T5-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hanjun,

    What branch is this patch for ? Check v4.12, failed to apply.

Thanks,
Ethan

On Thu, Jul 6, 2017 at 12:35 PM, Hanjun Guo <guohanjun@huawei.com> wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
>
> is_fwnode_irqchip() already check fwnode is NULL or not,
> just use is_fwnode_irqchip() directly.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
>  kernel/irq/irqdomain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 1bc38fa..14a21a3 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -137,7 +137,7 @@ struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size,
>         if (WARN_ON(!domain))
>                 return NULL;
>
> -       if (fwnode && is_fwnode_irqchip(fwnode)) {
> +       if (is_fwnode_irqchip(fwnode)) {
>                 fwid = container_of(fwnode, struct irqchip_fwid, fwnode);
>
>                 switch (fwid->type) {
> --
> 1.7.12.4
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] genirq: Get the fwnode back for irqchips being probed via ACPI namespace Hanjun Guo <guohanjun@huawei.com> - 2017-07-06 06:50 +0200
  [PATCH 2/2] genirq: Use is_fwnode_irqchip() directly Hanjun Guo <guohanjun@huawei.com> - 2017-07-06 06:50 +0200
    Re: [PATCH 2/2] genirq: Use is_fwnode_irqchip() directly Ethan Zhao <ethan.kernel@gmail.com> - 2017-07-06 07:50 +0200
      Re: [PATCH 2/2] genirq: Use is_fwnode_irqchip() directly Hanjun Guo <guohanjun@huawei.com> - 2017-07-06 08:30 +0200
  Re: [PATCH 1/2] genirq: Get the fwnode back for irqchips being probed  via ACPI namespace Marc Zyngier <marc.zyngier@arm.com> - 2017-07-06 09:50 +0200
    Re: [PATCH 1/2] genirq: Get the fwnode back for irqchips being probed  via ACPI namespace Marc Zyngier <marc.zyngier@arm.com> - 2017-07-06 15:10 +0200
      Re: [PATCH 1/2] genirq: Get the fwnode back for irqchips being probed  via ACPI namespace Hanjun Guo <guohanjun@huawei.com> - 2017-07-07 05:40 +0200
        Re: [PATCH 1/2] genirq: Get the fwnode back for irqchips being probed  via ACPI namespace Marc Zyngier <marc.zyngier@arm.com> - 2017-07-07 10:20 +0200
          Re: [PATCH 1/2] genirq: Get the fwnode back for irqchips being probed  via ACPI namespace Hanjun Guo <guohanjun@huawei.com> - 2017-07-07 11:40 +0200

csiph-web