Path: csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From: Ethan Zhao <ethan.kernel@gmail.com>
Newsgroups: linux.kernel
Subject: Re: [PATCH 2/2] genirq: Use is_fwnode_irqchip() directly
Date: Thu, 06 Jul 2017 07:50:01 +0200
Message-ID: <u07PP-eU-7@gated-at.bofh.it>
References: <u06TL-7T5-7@gated-at.bofh.it> <u06TL-7T5-9@gated-at.bofh.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 36
Organization: linux.* mail to news gateway
Xref: csiph.com linux.kernel:1682056

Hanjun=EF=BC=8C

    What branch is this patch for ? Check v4.12, failed to apply.

Thanks,
Ethan

On Thu, Jul 6, 2017 at 12:35 PM, Hanjun Guo <guohanjun@huawei.com> wrote:
> From: Hanjun Guo <hanjun.guo@linaro.org>
>
> is_fwnode_irqchip() already check fwnode is NULL or not,
> just use is_fwnode_irqchip() directly.
>
> Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
> ---
>  kernel/irq/irqdomain.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 1bc38fa..14a21a3 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -137,7 +137,7 @@ struct irq_domain *__irq_domain_add(struct fwnode_han=
dle *fwnode, int size,
>         if (WARN_ON(!domain))
>                 return NULL;
>
> -       if (fwnode && is_fwnode_irqchip(fwnode)) {
> +       if (is_fwnode_irqchip(fwnode)) {
>                 fwid =3D container_of(fwnode, struct irqchip_fwid, fwnode=
);
>
>                 switch (fwid->type) {
> --
> 1.7.12.4
>