Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block
Date	2017-04-24 17:50 +0200
Message-ID	<tzOpt-mK-43@gated-at.bofh.it> (permalink)
References	<tv0KC-5hT-13@gated-at.bofh.it> <tv0KC-5hT-27@gated-at.bofh.it> <tvaTE-3ut-5@gated-at.bofh.it> <tvjkf-Bv-29@gated-at.bofh.it> <tvkJj-1zn-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Oleksij,

Am 12.04.2017 um 09:15 schrieb Oleksij Rempel:
> On Tue, Apr 11, 2017 at 10:48:28PM -0700, Christoph Hellwig wrote:
>> On Tue, Apr 11, 2017 at 10:43:26PM +0200, Richard Weinberger wrote:
>>> Artem, do you remember why UBIFS didn't set s_uuid in first place?
>>
>> It's an extremely odd field - only a hand full of file systems set it
>> (e.g. XFS doesn't, although according to Mimi IMA supports XFS), and
>> it's never even used outside of the IMA/EVM code.
>>
>> We really need a feature flag that this field is valid that IMA can
>> check before adding more support for it.
> 
> It seems to be used by mm/cleancache.c
> void __cleancache_init_shared_fs()
> 
> but this affects only ocfs2.
> 
> So, if some flag should be implemented, who should do it? :)

I'll not do it for you. ;)

> If me, what flag should be created?

A super block flag that denotes that s_uuid is valid.

Thanks,
//richard

Thread

[PATCH v2 0/3] make ubifs compatible with IMA and EVM. Oleksij Rempel <o.rempel@pengutronix.de> - 2017-04-11 12:00 +0200
  [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Oleksij Rempel <o.rempel@pengutronix.de> - 2017-04-11 12:00 +0200
    Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Richard Weinberger <richard@nod.at> - 2017-04-11 22:50 +0200
      Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Christoph Hellwig <hch@infradead.org> - 2017-04-12 07:50 +0200
        Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Oleksij Rempel <ore@pengutronix.de> - 2017-04-12 09:20 +0200
          Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Richard Weinberger <richard@nod.at> - 2017-04-24 17:50 +0200
            Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Richard Weinberger <richard@nod.at> - 2017-04-28 00:10 +0200
              Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Amir Goldstein <amir73il@gmail.com> - 2017-04-28 11:00 +0200
                Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Oleksij Rempel <ore@pengutronix.de> - 2017-05-02 07:40 +0200
              Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Amir Goldstein <amir73il@gmail.com> - 2017-05-02 09:30 +0200
                Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Richard Weinberger <richard@nod.at> - 2017-05-02 09:40 +0200
                Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Oleksij Rempel <ore@pengutronix.de> - 2017-05-09 06:20 +0200
                Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Oleksij Rempel <ore@pengutronix.de> - 2017-05-09 08:00 +0200
                Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Amir Goldstein <amir73il@gmail.com> - 2017-05-09 09:10 +0200
                Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Oleksij Rempel <ore@pengutronix.de> - 2017-05-09 09:40 +0200
                Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Richard Weinberger <richard@nod.at> - 2017-05-09 09:40 +0200
                Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Amir Goldstein <amir73il@gmail.com> - 2017-05-09 10:00 +0200
                Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Richard Weinberger <richard@nod.at> - 2017-05-09 09:10 +0200
      Re: [PATCH v2 3/3] fs: ubifs: set s_uuid in super block Artem Bityutskiy <dedekind1@gmail.com> - 2017-05-02 09:30 +0200
  [PATCH v2 2/3] fs: ubifs: update i_version on inode changes Oleksij Rempel <o.rempel@pengutronix.de> - 2017-04-11 12:00 +0200
    Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes Christoph Hellwig <hch@infradead.org> - 2017-04-11 18:10 +0200
      Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes Richard Weinberger <richard@nod.at> - 2017-04-11 23:20 +0200
        Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes Oleksij Rempel <ore@pengutronix.de> - 2017-04-12 08:10 +0200
          Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes Christoph Hellwig <hch@infradead.org> - 2017-04-12 08:10 +0200
            Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes Oleksij Rempel <ore@pengutronix.de> - 2017-04-12 09:10 +0200
              Re: [PATCH v2 2/3] fs: ubifs: update i_version on inode changes Richard Weinberger <richard@nod.at> - 2017-04-24 17:50 +0200
  [PATCH v2 1/3] fs: ubifs: parse iversion mount option Oleksij Rempel <o.rempel@pengutronix.de> - 2017-04-11 12:00 +0200

csiph-web