Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro
Date	2017-04-24 17:50 +0200
Message-ID	<tzOpt-mK-39@gated-at.bofh.it> (permalink)
References	<tzqwN-17x-3@gated-at.bofh.it> <tzrVT-1OD-1@gated-at.bofh.it> <tzDkl-1vZ-3@gated-at.bofh.it> <tzG8y-3DA-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 24, 2017 at 12:19:18PM +0530, Rahul Bedarkar wrote:
> Hello Guenter, Heiko,
> 
> On Mon, Apr 24, 2017 at 9:28 AM, Heiko Schocher <hs@denx.de> wrote:
> > Hello Guenter, Rahul,
> >
> > Hmm.. I like this patch too, but have also no idea, what is preffered.
> >
> > Looking into drivers/hwmon
> >
> > pollux:linux hs [master] $ grep -lr __maybe_unused drivers/hwmon/
> > drivers/hwmon/tmp108.c
> > drivers/hwmon/nct6775.c
> > drivers/hwmon/hwmon-vid.c
> > drivers/hwmon/max31722.c
> >
> > Ok, there are hwmon drivers, which use this version already ...
> 
> Yes, some hwmon drivers already use this approach. Some drivers in
> other sub systems also using it from start or moving towards this
> approach.
> 
Yes, but as I mentioned it is unsettled if one or the other approach
is preferred, which makes me a bit wary. I'll be open to accepting
patches for jc42 and nct6883 since I am the author of those drivers.

Thanks,
Guenter

> >
> > pollux:linux hs [master] $ grep -lr CONFIG_PM drivers/hwmon/
> > drivers/hwmon/max6639.c
> > drivers/hwmon/jc42.c
> > drivers/hwmon/fam15h_power.c
> > drivers/hwmon/tmp102.c
> > drivers/hwmon/gpio-fan.c
> > drivers/hwmon/pwm-fan.c
> > drivers/hwmon/tmp103.c
> > drivers/hwmon/pmbus/Makefile
> > drivers/hwmon/lm75.c
> > drivers/hwmon/nct6683.c
> > drivers/hwmon/adt7x10.h
> > drivers/hwmon/w83627hf.c
> > drivers/hwmon/abituguru3.c
> > drivers/hwmon/Makefile
> > drivers/hwmon/acpi_power_meter.c
> > drivers/hwmon/adt7x10.c
> > drivers/hwmon/abituguru.c
> > drivers/hwmon/w83627ehf.c
> >
> > May this conversion should be done in a patch, which touches more
> > devices?
> 
> I'm happy send patches converting remaining drivers once this is
> settled or accepted.
> 
> Thanks for your reviews.
> 
> Regards,
> Rahul

Thread

[PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro Rahul Bedarkar <rahulbedarkar89@gmail.com> - 2017-04-23 16:20 +0200
  Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro Guenter Roeck <linux@roeck-us.net> - 2017-04-23 17:50 +0200
    Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro Heiko Schocher <hs@denx.de> - 2017-04-24 06:00 +0200
      Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro Rahul Bedarkar <rahulbedarkar89@gmail.com> - 2017-04-24 09:00 +0200
        Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro Guenter Roeck <linux@roeck-us.net> - 2017-04-24 17:50 +0200
      Re: [PATCH] hwmon: tmp103: use SIMPLE_DEV_PM_OPS helper macro Guenter Roeck <linux@roeck-us.net> - 2017-04-24 17:50 +0200

csiph-web