Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11

From	Andy Lutomirski <luto@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11
Date	2017-04-20 18:10 +0200
Message-ID	<tymOC-2ES-21@gated-at.bofh.it> (permalink)
References	<tyaDL-3Au-1@gated-at.bofh.it> <tyaNs-3Dz-1@gated-at.bofh.it> <tybq9-3PD-1@gated-at.bofh.it> <tycmd-4qe-3@gated-at.bofh.it> <tycFz-4MR-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Apr 19, 2017 at 10:19 PM, Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Apr 19, 2017 at 09:52:17PM -0700, Andy Lutomirski wrote:
>> > I can make it so that force_apst=0 means no APST and force_apst=1 mean
>> > yes APST and we could try again with a quirk list for 4.12.  There's a
>> > decent chance that a few more weeks with Ubuntu having APST on will
>> > shake out all the problems fairly quickly.
>>
>> Here's a more concrete and more sensible proposal:
>
> Can we just have force_apst=on to force it on, force_apst=off to turn
> it off, and leave it with that?  And yes, I mean the strings instead
> of the weird numbers.

That's essentially what the patch I emailed here does -- it's a
regular bool param, so force_apst=1, force_apst=Y, and force_apst=y
all mean the same thing.  I can just leave it like that.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] nvme APST fixes/improvements for 4.11 Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk Jens Axboe <axboe@kernel.dk> - 2017-04-20 05:10 +0200
    Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk Andy Lutomirski <luto@kernel.org> - 2017-04-20 06:00 +0200
      RE: [PATCH 4/5] nvme: Adjust the Samsung APST quirk Judy Brock <judy.brock@samsung.com> - 2017-04-20 06:50 +0200
  [PATCH 2/5] nvme: Display raw APST configuration via DYNAMIC_DEBUG Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  [PATCH 4/5] nvme: Adjust the Samsung APST quirk Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  [PATCH 5/5] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA" Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  [PATCH 1/5] nvme: Fix APST comment Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  [PATCH 3/5] nvme: Add nvme_core.force_apst to ignore the NO_APST quirk Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Jens Axboe <axboe@kernel.dk> - 2017-04-20 05:20 +0200
    Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Andy Lutomirski <luto@kernel.org> - 2017-04-20 06:00 +0200
      Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Andy Lutomirski <luto@amacapital.net> - 2017-04-20 07:00 +0200
        Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Christoph Hellwig <hch@lst.de> - 2017-04-20 07:20 +0200
          Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Andy Lutomirski <luto@kernel.org> - 2017-04-20 18:10 +0200

csiph-web