Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1626962

Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk

Show all headers | View raw

On Wed, Apr 19, 2017 at 8:07 PM, Jens Axboe <axboe@kernel.dk> wrote:
> On Wed, Apr 19 2017, Andy Lutomirski wrote:
>> I got a couple more reports: the Samsung APST issues appears to
>> affect multiple 950-series devices in Dell XPS 15 9550 and Precision
>> 5510 laptops.  Change the quirk: rather than blacklisting the
>> firmware on the first problematic SSD that was reported, disable
>> APST on all 144d:a802 devices if they're installed in the two
>> affected Dell models.  While we're at it, disable only the deepest
>> sleep state instead of all of them -- the reporters say that this is
>> sufficient to fix the problem.
>>
>> (I have a device that appears to be entirely identical to one of the
>> affected devices, but I have a different Dell laptop, so it's not
>> the case that all Samsung devices with firmware BXW75D0Q are broken
>> under all circumstances.)
>>
>> Samsung engineers have an affected system, and hopefully they'll
>> give us a better workaround some time soon.  In the mean time, this
>> should minimize regressions.
>
> Do we know for a fact that it only happens on those systems, and isn't
> purely specific to the device?

I have decent evidence.  All of the reports are from XPS 15 9550 or
Precision 5510, and Dell confirmed that they're basically the same
machine and run literally the same BIOS.  One of these reports is from
a device with exactly the same model and firmware as my SSD, and mine
is fine.  (I have a different laptop.)

>
> At this point in time, I'd be much more comfortable completely disabling
> APST on Samsung, period.
>

I'd be fine with doing that for 4.11 and then doing this for 4.12-rc1.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] nvme APST fixes/improvements for 4.11 Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk Jens Axboe <axboe@kernel.dk> - 2017-04-20 05:10 +0200
    Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk Andy Lutomirski <luto@kernel.org> - 2017-04-20 06:00 +0200
      RE: [PATCH 4/5] nvme: Adjust the Samsung APST quirk Judy Brock <judy.brock@samsung.com> - 2017-04-20 06:50 +0200
  [PATCH 2/5] nvme: Display raw APST configuration via DYNAMIC_DEBUG Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  [PATCH 4/5] nvme: Adjust the Samsung APST quirk Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  [PATCH 5/5] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA" Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  [PATCH 1/5] nvme: Fix APST comment Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  [PATCH 3/5] nvme: Add nvme_core.force_apst to ignore the NO_APST quirk Andy Lutomirski <luto@kernel.org> - 2017-04-20 05:10 +0200
  Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Jens Axboe <axboe@kernel.dk> - 2017-04-20 05:20 +0200
    Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Andy Lutomirski <luto@kernel.org> - 2017-04-20 06:00 +0200
      Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Andy Lutomirski <luto@amacapital.net> - 2017-04-20 07:00 +0200
        Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Christoph Hellwig <hch@lst.de> - 2017-04-20 07:20 +0200
          Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Andy Lutomirski <luto@kernel.org> - 2017-04-20 18:10 +0200

csiph-web