Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1628463
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() |
| Date | 2017-04-21 20:40 +0200 |
| Message-ID | <tyLDk-LM-33@gated-at.bofh.it> (permalink) |
| References | <txTMD-1zl-49@gated-at.bofh.it> <txTWh-1CP-5@gated-at.bofh.it> <tyF4R-5fu-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2017-04-21 at 19:36 +0800, Herbert Xu wrote:
> On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Wed, 19 Apr 2017 10:50:04 +0200
> >
> > The script "checkpatch.pl" pointed information out like the following.
> >
> > WARNING: quoted string split across lines
> >
> > Thus fix the affected source code places.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>
> This patch doesn't seem to add any value so I'm not taking it.
Your choice.
The general reason to merge strings is in CodingStyle
2) Breaking long lines and strings
[]
never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] n2rng: Fine-tuning for n2rng_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-19 11:10 +0200
[PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-19 11:20 +0200
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() Shannon Nelson <shannon.nelson@oracle.com> - 2017-04-19 17:30 +0200
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-21 13:40 +0200
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() Joe Perches <joe@perches.com> - 2017-04-21 20:40 +0200
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() David Miller <davem@davemloft.net> - 2017-04-21 20:40 +0200
[PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-19 11:20 +0200
Re: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() Shannon Nelson <shannon.nelson@oracle.com> - 2017-04-19 17:30 +0200
Re: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-21 15:20 +0200
csiph-web