Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1625968
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() |
| Date | 2017-04-19 11:20 +0200 |
| Message-ID | <txTWi-1CP-21@gated-at.bofh.it> (permalink) |
| References | <txTMD-1zl-49@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Wed, 19 Apr 2017 10:30:47 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kcalloc". * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/char/hw_random/n2-drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/char/hw_random/n2-drv.c b/drivers/char/hw_random/n2-drv.c index 31cbdbbaebfc..92dd4e925315 100644 --- a/drivers/char/hw_random/n2-drv.c +++ b/drivers/char/hw_random/n2-drv.c @@ -748,9 +748,7 @@ static int n2rng_probe(struct platform_device *op) dev_info(&op->dev, "Registered RNG HVAPI major %lu minor %lu\n", np->hvapi_major, np->hvapi_minor); - - np->units = devm_kzalloc(&op->dev, - sizeof(struct n2rng_unit) * np->num_units, + np->units = devm_kcalloc(&op->dev, np->num_units, sizeof(*np->units), GFP_KERNEL); err = -ENOMEM; if (!np->units) -- 2.12.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] n2rng: Fine-tuning for n2rng_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-19 11:10 +0200
[PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-19 11:20 +0200
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() Shannon Nelson <shannon.nelson@oracle.com> - 2017-04-19 17:30 +0200
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-21 13:40 +0200
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() Joe Perches <joe@perches.com> - 2017-04-21 20:40 +0200
Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe() David Miller <davem@davemloft.net> - 2017-04-21 20:40 +0200
[PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-04-19 11:20 +0200
Re: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() Shannon Nelson <shannon.nelson@oracle.com> - 2017-04-19 17:30 +0200
Re: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe() Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-21 15:20 +0200
csiph-web