Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1625546

Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode
Date 2017-04-18 21:00 +0200
Message-ID <txGw2-1bd-9@gated-at.bofh.it> (permalink)
References <tv4XU-8aE-5@gated-at.bofh.it> <tv4XU-8aE-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Apr 12, 2017 at 06:21:05AM +0800, Jin Yao wrote:

SNIP

> +const char *branch_type_name(int type)
> +{
> +	const char *branch_names[PERF_BR_MAX] = {
> +		"N/A",
> +		"JCC",
> +		"JMP",
> +		"IND_JMP",
> +		"CALL",
> +		"IND_CALL",
> +		"RET",
> +		"SYSCALL",
> +		"SYSRET",
> +		"IRQ",
> +		"INT",
> +		"IRET",
> +		"FAR_BRANCH",
> +	};
> +
> +	if ((type >= 0) && (type < PERF_BR_MAX))
> +		return branch_names[type];
> +
> +	return NULL;

looks like we should add util/branch.c with above functions
and merge it with util/parse-branch-options.c

we create new file even for less code ;-)

thanks,
jirka

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 4/5] perf report: Show branch type statistics for stdio mode Jin Yao <yao.jin@linux.intel.com> - 2017-04-11 16:30 +0200
  Re: [PATCH v4 4/5] perf report: Show branch type statistics for  stdio mode Jiri Olsa <jolsa@redhat.com> - 2017-04-18 21:00 +0200
    Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio  mode "Jin, Yao" <yao.jin@linux.intel.com> - 2017-04-19 02:50 +0200
  Re: [PATCH v4 4/5] perf report: Show branch type statistics for  stdio mode Jiri Olsa <jolsa@redhat.com> - 2017-04-18 21:00 +0200
    Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio  mode "Jin, Yao" <yao.jin@linux.intel.com> - 2017-04-19 03:00 +0200
      Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio  mode "Jin, Yao" <yao.jin@linux.intel.com> - 2017-04-19 06:20 +0200

csiph-web