Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1625543

Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode

From Jiri Olsa <jolsa@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio mode
Date 2017-04-18 21:00 +0200
Message-ID <txGw2-1bd-3@gated-at.bofh.it> (permalink)
References <tv4XU-8aE-5@gated-at.bofh.it> <tv4XU-8aE-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Apr 12, 2017 at 06:21:05AM +0800, Jin Yao wrote:

SNIP

> +static int hist_iter__branch_callback(struct hist_entry_iter *iter,
> +				      struct addr_location *al __maybe_unused,
> +				      bool single __maybe_unused,
> +				      void *arg)
> +{
> +	struct hist_entry *he = iter->he;
> +	struct report *rep = arg;
> +	struct branch_info *bi;
> +
> +	if (sort__mode == SORT_MODE__BRANCH) {

is this check necessary? the hist_iter__branch_callback
was set based on this check

jirka

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 4/5] perf report: Show branch type statistics for stdio mode Jin Yao <yao.jin@linux.intel.com> - 2017-04-11 16:30 +0200
  Re: [PATCH v4 4/5] perf report: Show branch type statistics for  stdio mode Jiri Olsa <jolsa@redhat.com> - 2017-04-18 21:00 +0200
    Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio  mode "Jin, Yao" <yao.jin@linux.intel.com> - 2017-04-19 02:50 +0200
  Re: [PATCH v4 4/5] perf report: Show branch type statistics for  stdio mode Jiri Olsa <jolsa@redhat.com> - 2017-04-18 21:00 +0200
    Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio  mode "Jin, Yao" <yao.jin@linux.intel.com> - 2017-04-19 03:00 +0200
      Re: [PATCH v4 4/5] perf report: Show branch type statistics for stdio  mode "Jin, Yao" <yao.jin@linux.intel.com> - 2017-04-19 06:20 +0200

csiph-web