Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1625344

Re: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

From Bjorn Helgaas <bhelgaas@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t
Date 2017-04-18 16:10 +0200
Message-ID <txBZo-779-7@gated-at.bofh.it> (permalink)
References <ti1O9-Yn-3@gated-at.bofh.it> <ti1XQ-146-35@gated-at.bofh.it> <ti9iH-6ij-37@gated-at.bofh.it> <titr4-3MX-13@gated-at.bofh.it> <txyRQ-57S-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena
<elena.reshetova@intel.com> wrote:
>
>
>> On Mon, 6 Mar 2017 15:38:29 -0600
>> Bjorn Helgaas <helgaas@kernel.org> wrote:
>>
>> > [+cc Hyper-V folks, -cc others]
>> >
>> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote:
>> > > refcount_t type and corresponding API should be
>> > > used instead of atomic_t when the variable is used as
>> > > a reference counter. This allows to avoid accidental
>> > > refcounter overflows that might lead to use-after-free
>> > > situations.
>> > >
>> > > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
>> > > Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
>> > > Signed-off-by: Kees Cook <keescook@chromium.org>
>> > > Signed-off-by: David Windsor <dwindsor@gmail.com>
>>
>>
>> Reviewed-by: Stephen Hemminger <sthemmin@microsoft.com>
>
> Getting back on this: could you take the patch via your tree or should I resubmit to some dedicated place with a new review-by added?

Sorry, for some reason I had assumed this would all go as part of the
larger series.  I applied it to my pci/host-hv branch with Stephen's
reviewed-by for v4.12.

Thanks for the ping!

Bjorn

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from  atomic_t to refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-04-18 12:50 +0200
  Re: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t  to refcount_t Bjorn Helgaas <bhelgaas@google.com> - 2017-04-18 16:10 +0200
    RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from  atomic_t to refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-04-18 16:30 +0200

csiph-web