Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625238 > unrolled thread

RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from  atomic_t to refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-04-18 12:50 +0200
    Re: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t  to refcount_t Bjorn Helgaas <bhelgaas@google.com> - 2017-04-18 16:10 +0200
      RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from  atomic_t to refcount_t "Reshetova, Elena" <elena.reshetova@intel.com> - 2017-04-18 16:30 +0200

#1625238 — RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

> On Mon, 6 Mar 2017 15:38:29 -0600
> Bjorn Helgaas <helgaas@kernel.org> wrote:
> 
> > [+cc Hyper-V folks, -cc others]
> >
> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote:
> > > refcount_t type and corresponding API should be
> > > used instead of atomic_t when the variable is used as
> > > a reference counter. This allows to avoid accidental
> > > refcounter overflows that might lead to use-after-free
> > > situations.
> > >
> > > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
> > > Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
> > > Signed-off-by: Kees Cook <keescook@chromium.org>
> > > Signed-off-by: David Windsor <dwindsor@gmail.com>
> 
> 
> Reviewed-by: Stephen Hemminger <sthemmin@microsoft.com>

Getting back on this: could you take the patch via your tree or should I resubmit to some dedicated place with a new review-by added?

Best Regards,
Elena

[toc] | [next] | [standalone]

#1625344 — Re: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount_t

On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena
<elena.reshetova@intel.com> wrote:
>
>
>> On Mon, 6 Mar 2017 15:38:29 -0600
>> Bjorn Helgaas <helgaas@kernel.org> wrote:
>>
>> > [+cc Hyper-V folks, -cc others]
>> >
>> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote:
>> > > refcount_t type and corresponding API should be
>> > > used instead of atomic_t when the variable is used as
>> > > a reference counter. This allows to avoid accidental
>> > > refcounter overflows that might lead to use-after-free
>> > > situations.
>> > >
>> > > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
>> > > Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
>> > > Signed-off-by: Kees Cook <keescook@chromium.org>
>> > > Signed-off-by: David Windsor <dwindsor@gmail.com>
>>
>>
>> Reviewed-by: Stephen Hemminger <sthemmin@microsoft.com>
>
> Getting back on this: could you take the patch via your tree or should I resubmit to some dedicated place with a new review-by added?

Sorry, for some reason I had assumed this would all go as part of the
larger series.  I applied it to my pci/host-hv branch with Stephen's
reviewed-by for v4.12.

Thanks for the ping!

Bjorn

[toc] | [prev] | [next] | [standalone]

#1625363

> On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena
> <elena.reshetova@intel.com> wrote:
> >
> >
> >> On Mon, 6 Mar 2017 15:38:29 -0600
> >> Bjorn Helgaas <helgaas@kernel.org> wrote:
> >>
> >> > [+cc Hyper-V folks, -cc others]
> >> >
> >> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote:
> >> > > refcount_t type and corresponding API should be
> >> > > used instead of atomic_t when the variable is used as
> >> > > a reference counter. This allows to avoid accidental
> >> > > refcounter overflows that might lead to use-after-free
> >> > > situations.
> >> > >
> >> > > Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
> >> > > Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com>
> >> > > Signed-off-by: Kees Cook <keescook@chromium.org>
> >> > > Signed-off-by: David Windsor <dwindsor@gmail.com>
> >>
> >>
> >> Reviewed-by: Stephen Hemminger <sthemmin@microsoft.com>
> >
> > Getting back on this: could you take the patch via your tree or should I resubmit
> to some dedicated place with a new review-by added?
> 
> Sorry, for some reason I had assumed this would all go as part of the
> larger series.  I applied it to my pci/host-hv branch with Stephen's
> reviewed-by for v4.12.

Thank you very much! I think I confused everyone in the beginning, but later on we decided that it is better off in small chunks and separate tress. 

Best Regards,
Elena.
> 
> Thanks for the ping!
> 
> Bjorn

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web