Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625342

[PATCH][net-next] esp6: fix incorrect null pointer check on xo

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The check for xo being null is incorrect, currently it is checking
for non-null, it should be checking for null.

Detected with CoverityScan, CID#1429349 ("Dereference after null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/ipv6/esp6_offload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv6/esp6_offload.c b/net/ipv6/esp6_offload.c
index 1cceeee7cc33..95f10728abaa 100644
--- a/net/ipv6/esp6_offload.c
+++ b/net/ipv6/esp6_offload.c
@@ -120,7 +120,7 @@ static struct sk_buff *esp6_gso_segment(struct sk_buff *skb,
 	netdev_features_t esp_features = features;
 	struct xfrm_offload *xo = xfrm_offload(skb);
 
-	if (xo)
+	if (!xo)
 		goto out;
 
 	seq = xo->seq.low;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH][net-next] esp6: fix incorrect null pointer check on xo Colin King <colin.king@canonical.com> - 2017-04-18 16:10 +0200
  Re: [PATCH][net-next] esp6: fix incorrect null pointer check on xo Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-18 22:20 +0200

csiph-web