Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625342 > unrolled thread

[PATCH][net-next] esp6: fix incorrect null pointer check on xo

Back to article view | Back to linux.kernel

Contents

  [PATCH][net-next] esp6: fix incorrect null pointer check on xo Colin King <colin.king@canonical.com> - 2017-04-18 16:10 +0200
    Re: [PATCH][net-next] esp6: fix incorrect null pointer check on xo Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-18 22:20 +0200

#1625342 — [PATCH][net-next] esp6: fix incorrect null pointer check on xo

From: Colin Ian King <colin.king@canonical.com>

The check for xo being null is incorrect, currently it is checking
for non-null, it should be checking for null.

Detected with CoverityScan, CID#1429349 ("Dereference after null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/ipv6/esp6_offload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv6/esp6_offload.c b/net/ipv6/esp6_offload.c
index 1cceeee7cc33..95f10728abaa 100644
--- a/net/ipv6/esp6_offload.c
+++ b/net/ipv6/esp6_offload.c
@@ -120,7 +120,7 @@ static struct sk_buff *esp6_gso_segment(struct sk_buff *skb,
 	netdev_features_t esp_features = features;
 	struct xfrm_offload *xo = xfrm_offload(skb);
 
-	if (xo)
+	if (!xo)
 		goto out;
 
 	seq = xo->seq.low;
-- 
2.11.0

[toc] | [next] | [standalone]

#1625627

It's in Steffen's tree, not the networking tree and he's not CC'd.  You
should really be adding Fixes tags because it helps to ensure you CC the
guilty parties.

regards,
dan carpenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web